> On May 2, 2013, 12:33 a.m., Jarek Cecho wrote:
> > dist/src/main/bin/sqoop.sh, lines 51-53
> > <https://reviews.apache.org/r/10689/diff/2/?file=286744#file286744line51>
> >
> >     Nit: It seems that the cd on line 50 is not necessary as we've already 
> > changed the working directory on line 48 if I'm not mistaken.

Hi Jarcec,
At line 48, just getting value and not actually changing directory. I tried 
'pwd' command at before and after the 48th line, prints same path. Only at line 
50, actually changing directory path. 
Even I removed line 50 as per your suggestion, getting execution error at line 
93.

Thanks,
Vasanth kumar


- vasanthkumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/#review20040
-----------------------------------------------------------


On May 1, 2013, 7:02 p.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10689/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 7:02 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Problem while starting and stopping sqoop server.
> Patch supports softlink for both server and client command. 
> 
> 
> This addresses bug SQOOP-1003.
>     https://issues.apache.org/jira/browse/SQOOP-1003
> 
> 
> Diffs
> -----
> 
>   dist/src/main/bin/sqoop.sh a218441 
> 
> Diff: https://reviews.apache.org/r/10689/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>

Reply via email to