> On May 6, 2013, 4:32 a.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/manager/OracleManager.java, lines 743-744 > > <https://reviews.apache.org/r/10943/diff/1/?file=288059#file288059line743> > > > > Do you think that we can use StringUtils.join(collection, ",") instead > > of the "Arrays.toString()?
Thanks Jarek. Fixed this > On May 6, 2013, 4:32 a.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/manager/SqlManager.java, lines 201-202 > > <https://reviews.apache.org/r/10943/diff/1/?file=288060#file288060line201> > > > > Do you think that we can use StringUtils.join(collection, ",") instead > > of the "Arrays.toString()? Fixed this to use StringUtils.join. Also removed unused variable result. - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10943/#review20173 ----------------------------------------------------------- On May 6, 2013, 5:04 a.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10943/ > ----------------------------------------------------------- > > (Updated May 6, 2013, 5:04 a.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > Provides an overridden implementation to get column names and types that > obeys the way Oracle DBMetadata provides procedure metadata > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/OracleManager.java 1999344 > src/java/org/apache/sqoop/manager/SqlManager.java 6952b9e > > Diff: https://reviews.apache.org/r/10943/diff/ > > > Testing > ------- > > Tested with Oracle 11g > > > Thanks, > > Venkat Ranganathan > >
