----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11288/#review20884 -----------------------------------------------------------
Ship it! The changes looks good to me, I'll run tests for all supported hadoop version prior committing. Please do attach your patch to the JIRA so that I can commit it. - Jarek Cecho On May 21, 2013, 6:57 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11288/ > ----------------------------------------------------------- > > (Updated May 21, 2013, 6:57 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > I updated the build and ivy settings to build Sqoop with Hadoop 2.0.4 alpha. > One of the compression tests (testBzip2TextCompression) fails with the > following stack trace > Testcase: testBzip2TextCompression took 1.21 sec > Caused an ERROR > null > java.lang.NullPointerException > at > org.apache.hadoop.io.compress.bzip2.Bzip2Factory.isNativeBzip2Loaded(Bzip2Factory.java:54) > at > org.apache.hadoop.io.compress.bzip2.Bzip2Factory.getBzip2Decompressor(Bzip2Factory.java:123) > at > org.apache.hadoop.io.compress.BZip2Codec.createDecompressor(BZip2Codec.java:250) > at > org.apache.hadoop.io.compress.BZip2Codec.createInputStream(BZip2Codec.java:156) > at > com.cloudera.sqoop.TestCompression.runTextCompressionTest(TestCompression.java:170) > at > com.cloudera.sqoop.TestCompression.testBzip2TextCompression(TestCompression.java:189) > The reason is in 2.0.4, with native BZip2 codec, the configuration is checked > and we don't do setConf for BZip2 codec. Fixed the test to set the > configuration irrespective of whether it was passed in or we created the > codec. > > > Diffs > ----- > > build.xml 1c33fee > src/test/com/cloudera/sqoop/TestCompression.java 048b87d > > Diff: https://reviews.apache.org/r/11288/diff/ > > > Testing > ------- > > Ran tests with the new settings and all tests pass > > > Thanks, > > Venkat Ranganathan > >
