----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11561/#review21215 -----------------------------------------------------------
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java <https://reviews.apache.org/r/11561/#comment44068> I know this wild long value is not good, but I really know where to put this constants. Can you guys help me with some suggestions? It will be greatly appreciated. I have thought about add a constant variable in the Constants.java or even in property files. However, there is no similar constant variable existing in any of these 2 files. So I really have no idea which way, these 2 or some other ways, is better. - Mengwei Ding On May 30, 2013, 11:36 p.m., Mengwei Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11561/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 11:36 p.m.) > > > Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek. > > > Description > ------- > > commit 4e011751033d565b8817edfe04757d9104e2f3a0 > Author: Mengwei Ding <[email protected]> > Date: Thu May 30 16:30:53 2013 -0700 > > SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option > for sqoop > > :100644 100644 979b892... 866f3b8... M > client/src/main/java/org/apache/sqoop/client/core/Constants.java > :100644 100644 9414b7d... a583982... M > client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java > :100644 100644 f6d1267... 8bc41d2... M > client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java > :100644 100644 890ede1... 8eff046... M > client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java > :100644 100644 f04b1fd... 04bcf45... M > client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java > :100644 100644 e328f9a... bbc8313... M > client/src/main/resources/client-resource.properties > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892 > client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java > 9414b7d > client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java > f6d1267 > client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java > 890ede1 > > client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java > f04b1fd > client/src/main/resources/client-resource.properties e328f9a > > Diff: https://reviews.apache.org/r/11561/diff/ > > > Testing > ------- > > > Thanks, > > Mengwei Ding > >
