----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11524/#review21299 -----------------------------------------------------------
Hi Raghav, Thank you very much for working on this! I do have just one minor suggestion: src/java/org/apache/sqoop/tool/ImportTool.java <https://reviews.apache.org/r/11524/#comment44182> I would recommend putting this method into ConnManager class so that connectors can override it to specify additional textual columns if needed. Jarcec - Jarek Cecho On May 29, 2013, 5:19 p.m., Raghav Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11524/ > ----------------------------------------------------------- > > (Updated May 29, 2013, 5:19 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Incremental import with text column as criteria should fail fast. The patch > does this. > > > This addresses bug SQOOP-976. > https://issues.apache.org/jira/browse/SQOOP-976 > > > Diffs > ----- > > src/docs/user/import.txt ee10b1c > src/java/org/apache/sqoop/tool/ImportTool.java 2627726 > src/test/com/cloudera/sqoop/TestIncrementalImport.java cab77ec > > Diff: https://reviews.apache.org/r/11524/diff/ > > > Testing > ------- > > I have added new test for this and all the tests pass. > > > Thanks, > > Raghav Gautam > >
