----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12240/#review22816 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On July 4, 2013, 2:45 a.m., Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12240/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 2:45 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1118 > https://issues.apache.org/jira/browse/SQOOP-1118 > > > Repository: sqoop-trunk > > > Description > ------- > > Attached patch includes following changes: > 1. codes in org.apache.sqoop.mapreduce are moved to > org.apache.sqoop.mapreduce.postgresql, > 2. settings for PGBulkloadManagerManualTest such as database, and username > ,tablespace and path of pg_bulkload are made configurable via system property, > 3. using not Configuration but JobConf in PGBulkloadManagerManualTest to > follow changes in DBConfiguration, > 4. handling for the case JdbcUrl.getPort returns -1 is added to > PGBulkloadExportMapper. > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/PGBulkloadManager.java 091fd15 > src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java cc60233 > src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java 81b1333 > src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java 6f55861 > src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportReducer.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/12240/diff/ > > > Testing > ------- > > passed PGBulkloadManagerManualTest on PostgreSQL 9.2.4 and pg_bulkload 3.1.3. > > > Thanks, > > Masatake Iwasaki > >
