-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12342/
-----------------------------------------------------------
(Updated July 9, 2013, 7:52 p.m.)
Review request for Sqoop.
Changes
-------
Thanks [~jarcec] for the reviews.
Updated with review comments
Bugs: SQOOP-1097
https://issues.apache.org/jira/browse/SQOOP-1097
Repository: sqoop-trunk
Description
-------
Fix for mysql export using procedure. While fixing this, found that Oracle
export also has additional issues when using DB specific types that are not
handled. Fixed both the issues and provided a generic implementation for
future db tests.
Diffs (updated)
-----
src/java/org/apache/sqoop/manager/ConnManager.java c9e05da
src/java/org/apache/sqoop/manager/MySQLManager.java 2090b1a
src/java/org/apache/sqoop/manager/OracleManager.java edc888e
src/java/org/apache/sqoop/manager/SqlManager.java e96368b
src/test/com/cloudera/sqoop/ThirdPartyTests.java 7fae052
src/test/org/apache/sqoop/TestExportUsingProcedure.java 6414ef7
src/test/org/apache/sqoop/manager/mysql/MySqlCallExportTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/oracle/OracleCallExportTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/12342/diff/
Testing
-------
All unit tests pass. Created a mysql and oracle specific test for testing both
the functionality of doing procedure based export and handling db specific types
Thanks,
Venkat Ranganathan
