-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12032/
-----------------------------------------------------------
(Updated July 10, 2013, 6:33 p.m.)
Review request for Sqoop.
Changes
-------
Here is a short summary of the changes:
1. Changes in ConnManager deal with getting the type of checkcolumn and making
sure that its type is either timestamp or date
2. Changes in OracleManager truncates the millisecond part of the time string,
without this oracle gives error
3. ImportTool changes: remove the hardcoding and use connection manager to get
the type of the checkcolumn
4. changes to TestIncrementalImport, TestMerge just uppercase the name of the
checkcolumn - because implementation of getLastModifiedCheckColumn in
ConnManager.java is sensitive to case, this is required
5. OracleIncrementalImportTest is new test added
6. Changes to BaseSqoopTest.java generalizes the function
createTableWithColTypesAndNames - earlier it could take only single data row
for populating the table; with my modifications it take take multiple data rows.
Bugs: SQOOP-906
https://issues.apache.org/jira/browse/SQOOP-906
Repository: sqoop-trunk
Description
-------
Incremental import using lastmodified mode always assumes column type to be
TIMESTAMP which is causing issues with Oracle Connector. This patch fixes that.
Diffs (updated)
-----
src/java/org/apache/sqoop/manager/ConnManager.java c84c859
src/java/org/apache/sqoop/manager/OracleManager.java 686bc19
src/java/org/apache/sqoop/tool/ImportTool.java cb800b6
src/test/com/cloudera/sqoop/TestIncrementalImport.java 02080df
src/test/com/cloudera/sqoop/TestMerge.java 5010cf2
src/test/com/cloudera/sqoop/ThirdPartyTests.java ada5c72
src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 877d7f8
src/test/org/apache/sqoop/manager/oracle/OracleIncrementalImportTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/12032/diff/
Testing
-------
Unit tests & oracle third party tests are passing. Also tested manually.
Thanks,
Raghav Gautam
