----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12370/#review23316 -----------------------------------------------------------
Thank you Mengwei for working on this JIRA! Couple of notes: core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/12370/#comment47196> If the purpose is to validate if the method is being called, wouldn't i be simpler to mock it with "noop" and use verify() to ensure that it was called? core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/12370/#comment47210> If the purpose is to validate if the method is being called, wouldn't i be simpler to mock it with "noop" and use verify() to ensure that it was called? core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/12370/#comment47211> Nit: "procedure connector upgrade procedure" core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/12370/#comment47212> Nit: Can be simplified to: Collections.addAll(connectors, cs); core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/12370/#comment47213> Nit: Can be simplified to: Collections.addAll(jobs, js); Jarcec - Jarek Cecho On July 9, 2013, 8:22 p.m., Mengwei Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12370/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 8:22 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-996 > https://issues.apache.org/jira/browse/SQOOP-996 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit b3602f1d6190926eeffa2fa10e81efdd6611092b > Author: Mengwei Ding <[email protected]> > Date: Wed Jul 3 15:56:49 2013 -0700 > > SQOOP-996: Sqoop2: create upgrade tests > > :100644 100644 0732b2c... 2b6e436... M core/pom.xml > :000000 100644 0000000... 47eb28c... A > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > > > Diffs > ----- > > core/pom.xml 0732b2c > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/12370/diff/ > > > Testing > ------- > > > Thanks, > > Mengwei Ding > >
