----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10964/#review23634 -----------------------------------------------------------
Hi Abe, thank you very much for incorporating all my comments, greatly appreciated! It seems that I'm having timeout issues in TableExportTest, are you observing them as well? test/src/main/java/org/apache/sqoop/test/hadoop/HadoopLocalRunner.java <https://reviews.apache.org/r/10964/#comment47533> Nit: I'm not sure that this sentence do make sense here. test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.java <https://reviews.apache.org/r/10964/#comment47534> Nit: Trailing white space. test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.java <https://reviews.apache.org/r/10964/#comment47536> Nit: Trailing white space. Jarcec - Jarek Cecho On July 19, 2013, 11:32 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10964/ > ----------------------------------------------------------- > > (Updated July 19, 2013, 11:32 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-927 > https://issues.apache.org/jira/browse/SQOOP-927 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit ff7dba55a09dd7789a34136233000c625759e583 > Author: Abraham Elmahrek <[email protected]> > Date: Fri Apr 26 15:10:24 2013 -0700 > > SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running > on MiniCluster > > Handle MiniDFSCluster and MiniMRClientCluster on own. > > Set yarn.application.classpath to get over classpath errors. > Set to use fair scheduler. > > :100644 100644 0abbb18... f09704b... M pom.xml > :100644 100644 6eb3184... a4c2a5b... M > test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java > :100644 100644 0f48a8b... 758c885... M > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > > > Diffs > ----- > > pom.xml 8785e01000cc6e7d5a74ffeb96b83d236a657df8 > test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java > 056e6124b918ce5821c389e388a0cdfa68fd7fc0 > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopLocalRunner.java > PRE-CREATION > > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunnerFactory.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > 6aeadd4e54e47e5644270b15813b2d9c4cedc059 > test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java > ca77e64486d80b38306b5b30e185e6278ad7eaf1 > test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java > 95dd177a11c5d822e35ca54e5d93785f0a40fbfc > > Diff: https://reviews.apache.org/r/10964/diff/ > > > Testing > ------- > > Ran integration tests without and with miniclusters. > Currently need to use both miniclusters or neither for tests to work. > > > Thanks, > > Abraham Elmahrek > >
