----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13524/#review25075 -----------------------------------------------------------
Ship it! Will commit after verifying with tests - Venkat Ranganathan On Aug. 13, 2013, 3:47 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13524/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 3:47 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1172 > https://issues.apache.org/jira/browse/SQOOP-1172 > > > Repository: sqoop-trunk > > > Description > ------- > > Tweaked the build system to support both HBase 0.94 and 0.95. > > > Diffs > ----- > > build.xml 1a2128815d8cab33a24d9d97fe7392d53215f2f1 > ivy.xml 63fdc80b6d8a0155ddc558126cf0082289f15372 > > Diff: https://reviews.apache.org/r/13524/diff/ > > > Testing > ------- > > It seems that ant do not accepts "*" for test case names, so one need to > execute them one by one: > > 1) Create list of HBase related test cases: > find . -iname "*HBase*Test.java" | cut -d"/" -f 8 | sed -re "s/.java//" > > hbase-tests > > 2) Execute each test case one-by-one > > 2.1) For HBase 0.95 on Hadoop 2.0.0: > for test in `cat hbase-tests`; do ant clean test -Dhadoopversion=200 > -Dhbaseprofile=95 -Dhbasecompatprofile=2 -Dtestcase=$test ; done > log > > 2.2) For HBase 0.95 on Hadoop 1.0.0: > for test in `cat hbase-tests`; do ant clean test -Dhadoopversion=100 > -Dhbaseprofile=95 -Dhbasecompatprofile=1 -Dtestcase=$test ; done > log > > 2.2) For HBase 0.94: > for test in `cat hbase-tests`; do ant clean test -Dhadoopversion=100 > -Dtestcase=$test ; done > log > > 3) See the results: > cat log | grep "\[junit\]" > > > Thanks, > > Jarek Cecho > >
