> On Aug. 14, 2013, 11:09 p.m., Jarek Cecho wrote: > > Hi Mengwei, > > thank you very much for working on this ticket! It seems to me that current > > changes won't print anything if there aren't any arguments. I would suggest > > to add a check controlling that either --all or --name are entered so that > > users are not confused. What do you think? > > Mengwei Ding wrote: > I thought about this before. Since other "show" functions do not output > any help info, I don't think it's good to do this for "show option" > specifically. So I didn't do this. > > Yes, I think enforcing at least one parameter is a good way to let user > know this. But I am thinking to improve the help message for "show" command > in a way that it shows all parameters for all functions. What do you think ?
Seems reasonable, thank you for the explanation Mengwei! - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13273/#review25191 ----------------------------------------------------------- On Aug. 5, 2013, 6:10 p.m., Mengwei Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13273/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2013, 6:10 p.m.) > > > Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho. > > > Bugs: SQOOP-1162 > https://issues.apache.org/jira/browse/SQOOP-1162 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 64ebb185e42578ec0138639780e4953e22d4cff9 > Author: Mengwei Ding <[email protected]> > Date: Mon Aug 5 10:47:29 2013 -0700 > > SQOOP-1162: Sqoop2: 'show option' should have help entry showing that > 'all' arg can be used > > :100644 100644 999790d... 7ebd4d3... M > client/src/main/java/org/apache/sqoop/client/core/Constants.java > :100644 100644 81c5612... 36b3ae8... M > client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java > :100644 100644 1a8f963... 610b6b2... M > client/src/main/resources/client-resource.properties > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/core/Constants.java 999790d > client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java > 81c5612 > client/src/main/resources/client-resource.properties 1a8f963 > > Diff: https://reviews.apache.org/r/13273/diff/ > > > Testing > ------- > > > Thanks, > > Mengwei Ding > >
