----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13963/#review25898 -----------------------------------------------------------
Ship it! Looks good to me. Thanks for making these changes Jarcec! - Arvind Prabhakar On Sept. 4, 2013, 9:53 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13963/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2013, 9:53 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1190 > https://issues.apache.org/jira/browse/SQOOP-1190 > > > Repository: sqoop-trunk > > > Description > ------- > > I've used reflection to find out what Shim layer is available. > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java > a109b4055633415dbfced23a1cb4109dc2575a05 > > Diff: https://reviews.apache.org/r/13963/diff/ > > > Testing > ------- > > Tested both with HCatalog 0.5 and current trunk (future 0.12). > > > Thanks, > > Jarek Cecho > >
