> On Sept. 11, 2013, 8:32 p.m., Erik Selin wrote:
> > src/java/org/apache/sqoop/orm/ClassWriter.java, line 841
> > <https://reviews.apache.org/r/13635/diff/3/?file=350922#file350922line841>
> >
> >     Since I think it's impossible to get timezones here I defaulted to this 
> > format. I'm considering adding a -0:00 timezone just for really solid 
> > iso8601 compliance (particularly for joda DateTime compatibility). Thoughts?

this might not be the right place to correct this, but im not sure if I want to 
deal with it here or let user applications have to deal with it. Stuff like 
Joda would load this with default timezones of the box its running on which is 
less then ideal... :/


- Erik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13635/#review26040
-----------------------------------------------------------


On Sept. 11, 2013, 8:18 p.m., Erik Selin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13635/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2013, 8:18 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1176
>     
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1176
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Adding support for storing imported data as JSON.
> 
> 
> Diffs
> -----
> 
>   ivy.xml d7486e0 
>   src/java/org/apache/sqoop/SqoopOptions.java 01805f9 
>   src/java/org/apache/sqoop/orm/ClassWriter.java 0adc718 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java e02a93b 
>   src/test/com/cloudera/sqoop/TestJsonImport.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13635/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erik Selin
> 
>

Reply via email to