----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14377/#review26845 -----------------------------------------------------------
Hi William, thank you very much for working on this functionality. It seems that the patch is not currently compilable, would you mind taking a look? I do have couple of random nits below: src/docs/user/hbase-args.txt <https://reviews.apache.org/r/14377/#comment52198> Can we also provide paragraph about the parameter in the file hbase.txt describing details for this parameter (usage, ...)? src/docs/user/hbase-args.txt <https://reviews.apache.org/r/14377/#comment52197> Nit: Trailing whitespace src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java <https://reviews.apache.org/r/14377/#comment52196> com.cloudera classes are provided for backward compatibility and should not be changed any more. src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java <https://reviews.apache.org/r/14377/#comment52195> com.cloudera classes are provided for backward compatibility and should not be changed any more. src/java/org/apache/sqoop/SqoopOptions.java <https://reviews.apache.org/r/14377/#comment52199> Super nit: Please use space between the comment and word "Column". src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java <https://reviews.apache.org/r/14377/#comment52202> Can we also verify that such column indeed exists? We should make sure that user won't try to pass column name that is not being imported. src/java/org/apache/sqoop/mapreduce/HBaseImportMapper.java <https://reviews.apache.org/r/14377/#comment52200> This change do not seem to be relevant for the patch. If that is indeed the case, can we make a separate JIRA for it? Having one patch with multiple logical changes makes hard to use tools such as "git blame". src/java/org/apache/sqoop/tool/BaseSqoopTool.java <https://reviews.apache.org/r/14377/#comment52201> The exception here seems to be breaking the usual flow in parsing the arguments, is it intentional? Jarcec - Jarek Cecho On Oct. 7, 2013, 2:36 p.m., William Watson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14377/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2013, 2:36 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > See https://issues.apache.org/jira/browse/SQOOP-611 > > > Diffs > ----- > > src/docs/user/hbase-args.txt 8ba23eb > src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 425b0f4 > src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java a5f72f7 > src/java/org/apache/sqoop/SqoopOptions.java 01805f9 > src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 9ceb5bd > src/java/org/apache/sqoop/hbase/PutTransformer.java 8d6bcac > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 5ccf311 > src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java afc4299 > src/java/org/apache/sqoop/mapreduce/HBaseImportMapper.java 63e6cd3 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java ebb1857 > > Diff: https://reviews.apache.org/r/14377/diff/ > > > Testing > ------- > > > Thanks, > > William Watson > >
