----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16468/#review30878 -----------------------------------------------------------
Ship it! Looks good. Made a few comments on grammar, but I don't think it's unintelligable. Feel free to ignore or change as you see fit. Good stuff! docs/src/site/sphinx/Installation.rst <https://reviews.apache.org/r/16468/#comment59113> You can verify "the" Sqoop server configuration using `Verify Tool <Tools.html#verify>`_. For example:: docs/src/site/sphinx/Installation.rst <https://reviews.apache.org/r/16468/#comment59114> messages similar to the following:: docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59115> - trailing white space. - "administrator" should be "administrators". - "perform given task" should be "perform a given task". - "finish, there are" should be "finish. There are". Keep in mind the grammar check is a suggestion! docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59116> Can remove "itself" as "it" refers to an object, not a person. docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59117> "under a" docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59118> - with the parameter - followed by the desired tool name. docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59119> The verify tool will verify with the exception of docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59120> Might want to rephrase: If the verification process succeeds, you should see messages like: docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59121> Might want to rephrase: If the verification process will find any inconsistencies, it will print out the following message instead:: docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59122> Upgrades all versionable... This includes structural changes inside the repository... docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59123> No need for "similar message" I think docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/16468/#comment59124> Might want to slightly rephrase: "Execution failure will show the following::" docs/src/site/sphinx/Upgrade.rst <https://reviews.apache.org/r/16468/#comment59125> Might want to rephrase: "Backup instructions will vary depending on the repository implementation. For example, using MySQL as a repository will require a different back procedure than Apache Derby. Please follow the repositories' backup procedure. - Abraham Elmahrek On Dec. 26, 2013, 4:32 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16468/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2013, 4:32 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1262 > https://issues.apache.org/jira/browse/SQOOP-1262 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Provided documentation for existing tools. > > > Diffs > ----- > > docs/src/site/sphinx/Installation.rst > c25d394a60a00658383391e6dd51c90142b7bdbc > docs/src/site/sphinx/Tools.rst PRE-CREATION > docs/src/site/sphinx/Upgrade.rst 49a76c2d5e57ca718575bbf47697709dd3d19ce8 > docs/src/site/sphinx/index.rst f5d7d9263df5c3fabfcd1113496a7be431ade329 > > Diff: https://reviews.apache.org/r/16468/diff/ > > > Testing > ------- > > Built docs and checked the output. > > > Thanks, > > Jarek Cecho > >
