> On Feb. 4, 2014, 5:09 p.m., Jarek Cecho wrote: > > Couple of nits:
Thanks a lot for a quick review. I was trying to use a different eclipse bundle and this seems to be little more aggressive in importing packages. Let me try to fix the configuration. Sorry about that. > On Feb. 4, 2014, 5:09 p.m., Jarek Cecho wrote: > > src/docs/user/import.txt, lines 296-297 > > <https://reviews.apache.org/r/17650/diff/2/?file=463487#file463487line296> > > > > Can we further tweak this by also stating that not all connectors might > > following this argument? Sure. Good suggestion. > On Feb. 4, 2014, 5:09 p.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/SqoopOptions.java, line 304 > > <https://reviews.apache.org/r/17650/diff/2/?file=463488#file463488line304> > > > > I know that Java boolean will be false by default, but would you mind > > stating the default value in initDefaults() method as well? Will do. > On Feb. 4, 2014, 5:09 p.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java, line 25 > > <https://reviews.apache.org/r/17650/diff/2/?file=463489#file463489line25> > > > > Nit: Seems as unnecessary import. Fixed. Good catch > On Feb. 4, 2014, 5:09 p.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java, line 32 > > <https://reviews.apache.org/r/17650/diff/2/?file=463491#file463491line32> > > > > Nit: Seems as unnecessary import. Good catch. Fixed - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17650/#review33603 ----------------------------------------------------------- On Feb. 4, 2014, 6:22 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17650/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 6:22 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1278 > https://issues.apache.org/jira/browse/SQOOP-1278 > > > Repository: sqoop-trunk > > > Description > ------- > > Allow the use of read uncommitted isolation on all databases that support it. > Oracle does not read uncommitted as a settable option in the JDBC drivers so > it will behave as before on Oracle. > > > Diffs > ----- > > src/docs/user/common-args.txt 8a017f4 > src/docs/user/import.txt 0db6d97 > src/java/org/apache/sqoop/SqoopOptions.java 46e158c > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java b21560e > src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java be942ce > src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 73ed94e > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 6d6f1ea > src/test/com/cloudera/sqoop/TestSqoopOptions.java 686d398 > > Diff: https://reviews.apache.org/r/17650/diff/ > > > Testing > ------- > > One new test to test the option. Explicitly tested with Oracle, DB2 and > Postgresql. All unit tests passed > > > Thanks, > > Venkat Ranganathan > >
