----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22034/ -----------------------------------------------------------
(Updated May 30, 2014, 4:30 p.m.) Review request for Sqoop. Changes ------- Fixed the issues mentioned below: * added "finally" clause to close the base statement. * streamlined the conditions * straightened out the comments Repository: sqoop-sqoop2 Description ------- Adding a method to get all connectors to the repository API. Note that while this patch adds a new method, it also modifies the existing findConnector(String shortName) to avoid duplicating code. Diffs (updated) ----- core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 7768b13 core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 9299484 core/src/main/java/org/apache/sqoop/repository/Repository.java 4c7b866 repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java e4b30f9 repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 4f002bb repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java c470211 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java a1ad40d repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java cc3fe60 Diff: https://reviews.apache.org/r/22034/diff/ Testing ------- Added unit-test for the new method. Did basic repository functionality testing on a cluster. Thanks, Gwen Shapira
