-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23267/
-----------------------------------------------------------
Review request for Sqoop, Gwen Shapira, Hari Shreedharan, and Jarek Cecho.
Bugs: SQOOP-1356
https://issues.apache.org/jira/browse/SQOOP-1356
Repository: sqoop-sqoop2
Description
-------
commit 26620e7dbdb3200d611e451c6a12cab00e8e4095
Author: Abraham Elmahrek <[email protected]>
Date: Sat Dec 28 02:04:31 2013 -0800
SQOOP-1356 Sqoop2: Models and serialization for conditions
Added Serializers, models, and annotations.
Wire protocol: Conditions are at the form level.
:100644 100644 05ea6d6... 4d512d2... M
client/src/main/java/org/apache/sqoop/client/SqoopClient.java
:100644 100644 ffaa84f... f84d487... M
client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
:000000 100644 0000000... 8529d33... A
common/src/main/java/org/apache/sqoop/json/util/ConditionSerialization.java
:100644 100644 9558941... c73668d... M
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:000000 100644 0000000... e3f03c7... A
common/src/main/java/org/apache/sqoop/model/Condition.java
:100644 000000 27db8af... 0000000... D
common/src/main/java/org/apache/sqoop/model/FormUtils.java
:000000 100644 0000000... f0e46bd... A
common/src/main/java/org/apache/sqoop/model/MCondition.java
:100644 100644 ff94660... aece9b6... M
common/src/main/java/org/apache/sqoop/model/MForm.java
:000000 100644 0000000... b33e25a... A
common/src/main/java/org/apache/sqoop/model/util/ConditionUtils.java
:000000 100644 0000000... 01a9a92... A
common/src/main/java/org/apache/sqoop/model/util/FormUtils.java
:000000 100644 0000000... 9484410... A
common/src/test/java/org/apache/sqoop/json/util/TestConditionSerialization.java
:100644 100644 c4223ec... f1ea0d3... M
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java
:100644 000000 08dfa7b... 0000000... D
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java
:000000 100644 0000000... 6f68087... A
common/src/test/java/org/apache/sqoop/model/util/TestConditionUtils.java
:000000 100644 0000000... 6638ac5... A
common/src/test/java/org/apache/sqoop/model/util/TestFormUtils.java
:100644 100644 b80de7f... 117fee2... M
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
:100644 100644 505121c... 973b5e6... M
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
:100644 100644 e052584... c33cdbc... M
core/src/main/java/org/apache/sqoop/framework/JobManager.java
:100644 100644 ecf5004... a4f8806... M
core/src/main/java/org/apache/sqoop/repository/Repository.java
:100644 100644 d557b87... d535459... M
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
:100644 100644 bd11323... 1b88f71... M
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
:100644 100644 c9c7648... 6077b46... M
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 362ba79... f4ee1e3... M
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 656bc34... 461ca5e... M
test/src/main/java/org/apache/sqoop/test/utils/ParametrizedUtils.java
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 05ea6d6
client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
ffaa84f
common/src/main/java/org/apache/sqoop/json/util/ConditionSerialization.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
9558941
common/src/main/java/org/apache/sqoop/model/Condition.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/FormUtils.java 27db8af
common/src/main/java/org/apache/sqoop/model/MCondition.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/util/ConditionUtils.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/model/util/FormUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestConditionSerialization.java
PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java
c4223ec
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 08dfa7b
common/src/test/java/org/apache/sqoop/model/util/TestConditionUtils.java
PRE-CREATION
common/src/test/java/org/apache/sqoop/model/util/TestFormUtils.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java b80de7f
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 505121c
core/src/main/java/org/apache/sqoop/framework/JobManager.java e052584
core/src/main/java/org/apache/sqoop/repository/Repository.java ecf5004
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
d557b87
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
bd11323
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
c9c7648
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 362ba79
test/src/main/java/org/apache/sqoop/test/utils/ParametrizedUtils.java 656bc34
Diff: https://reviews.apache.org/r/23267/diff/
Testing
-------
Added a few tests. Also, testing manually to verify "conditions" show up in
connector/all and framework/all requests.
Connector/all:
{
"all": [
{
"class": "org.apache.sqoop.connector.jdbc.GenericJdbcConnector",
"con-forms": [
{
"conditions": [],
"id": 1,
"inputs": [
...
],
"name": "connection",
"type": "CONNECTION"
}
],
"id": 1,
"job-forms": {
"EXPORT": [
{
"conditions": [],
"id": 3,
"inputs": [
...
],
"name": "table",
"type": "CONNECTION"
}
],
"IMPORT": [
{
"conditions": [],
"id": 2,
"inputs": [
...
],
"name": "table",
"type": "CONNECTION"
}
]
},
"name": "generic-jdbc-connector",
"version": "2.0.0-SNAPSHOT"
}
]
}
Framework/all:
{
"con-forms": [
{
"conditions": [],
"id": 4,
"inputs": [
...
],
"name": "security",
"type": "CONNECTION"
}
],
"framework-version": "1",
"id": 1,
"job-forms": {
"EXPORT": [
{
"conditions": [],
"id": 7,
"inputs": [
...
],
"name": "input",
"type": "CONNECTION"
},
{
"conditions": [],
"id": 8,
"inputs": [
...
],
"name": "throttling",
"type": "CONNECTION"
}
],
"IMPORT": [
{
"conditions": [],
"id": 5,
"inputs": [
...
],
"name": "output",
"type": "CONNECTION"
},
{
"conditions": [],
"id": 6,
"inputs": [
...
],
"name": "throttling",
"type": "CONNECTION"
}
]
}
}
Thanks,
Abraham Elmahrek
