[
https://issues.apache.org/jira/browse/SQOOP-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091922#comment-14091922
]
Jarek Jarcec Cecho commented on SQOOP-1424:
-------------------------------------------
Summary of my changes:
* Removed all the code duplication in command implementations
* Provided reusable command implementation (with the function caching) in class
{{SqoopCommand}}
* Simplified class {{SqoopCommand}} a bit by
Future work (subsequent JIRAs):
* I left {{HelpCommand}} untouched, need to add good and usable help output
* Implementations of {{SqoopFunction}} also seems as good candidates for a
refactoring
> Sqoop2: Simply SqoopCommand in shell package
> --------------------------------------------
>
> Key: SQOOP-1424
> URL: https://issues.apache.org/jira/browse/SQOOP-1424
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.99.3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.4
>
> Attachments: SQOOP-1424.patch
>
>
> I've noticed that the {{SqoopCommand}} implementations are copy&pasting a lot
> of code. Would be great to simplify all that.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
