----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24586/#review50533 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Aug. 12, 2014, 1:03 a.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24586/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 1:03 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1429 > https://issues.apache.org/jira/browse/SQOOP-1429 > > > Repository: sqoop-trunk > > > Description > ------- > > Fixed the SQLServer connection manager get column details query and get > primary key query to properly prefix the string literals with N'...' prefix > as the information_schema uses native character set for table names > > Also fixed the Native splitter to use N'...' prefix for the strings generated > to be consistent > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/SQLServerManager.java 625f7cd > src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 6b30820 > src/java/org/apache/sqoop/mapreduce/db/NTextSplitter.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java 6c512aa > src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java e3d0c0c > > Diff: https://reviews.apache.org/r/24586/diff/ > > > Testing > ------- > > Tested with SQL Server with table names using native chars (characters not in > the default collation) and also tried using import-all-tables which exercises > to import all tables from a database schema with many tables with names > containing characters from non-default collation > > > Thanks, > > Venkat Ranganathan > >
