[
https://issues.apache.org/jira/browse/SQOOP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096366#comment-14096366
]
Abraham Elmahrek commented on SQOOP-1375:
-----------------------------------------
Good first shot! Went through it briefly and had a few comments:
* Connection information could include URI information or hostname + port, etc.
Cool to do in a follow up Jira. I might be dreaming, but JAAS information could
be added here as well. Just a thought.
{code}
@FormClass
public class ConnectionForm {
//Todo: Didn't find anything that belongs here...
}
{code}
* The MapReduce framework probably shouldn't be in charge of the output file or
compression any more now that things are more generic. There should be a way
for the user to configure these things or maybe we can generate unique
filenames.
{code}
public static final String HADOOP_COMPRESS_CODEC =
"mapred.output.compression.codec";
public static final String HADOOP_COMPRESS = "mapred.output.compress";
{code}
* For TO case, Totally.
{code}
@Override
public void destroy(DestroyerContext context, Object o, Object o2) {
//TODO: Add a "success" flag?
}
{code}
* For a follow up Jira, it might be cool to add user level configs to include
or exclude files.
{code}
@FormClass
public class InputForm {
@Input(size = 255) public String inputDirectory;
}
{code}
* Might be a good idea to add a user level config for filename template here.
For example, outputFilenameTemplate = "myoutput-${partition}.txt". Or something
of this nature. Follow up Jira if we do it.
{code}
@FormClass
public class OutputForm {
@Input public OutputFormat outputFormat;
@Input public OutputCompression compression;
@Input(size = 255) public String customCompression;
@Input(size = 255) public String outputDirectory;
}
{code}
> Sqoop2: From/To: Create HDFS connector
> --------------------------------------
>
> Key: SQOOP-1375
> URL: https://issues.apache.org/jira/browse/SQOOP-1375
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Abraham Elmahrek
> Assignee: Gwen Shapira
> Attachments: SQOOP-1375.2.patch, SQOOP-1375.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
