----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24818/#review50939 -----------------------------------------------------------
Ship it! common/src/main/java/org/apache/sqoop/common/DirectionError.java <https://reviews.apache.org/r/24818/#comment88823> Nit: We should fix the message as well? (probably in follow up JIRA). - Jarek Cecho On Aug. 18, 2014, 10:45 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24818/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2014, 10:45 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1417 > https://issues.apache.org/jira/browse/SQOOP-1417 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit 431bf410ec541fc3411049c7c81308fb172d0e82 > Author: Abraham Elmahrek <[email protected]> > Date: Mon Aug 18 15:42:36 2014 -0700 > > SQOOP-1417: Sqoop2: From/To: Change ConnectorType name > > :100644 100644 b42f234... 1d93ae3... M > client/src/main/java/org/apache/sqoop/client/SqoopClient.java > :100644 000000 d3d1d19... 0000000... D > common/src/main/java/org/apache/sqoop/common/ConnectorType.java > :100644 000000 e61addf... 0000000... D > common/src/main/java/org/apache/sqoop/common/ConnectorTypeError.java > :000000 100644 0000000... 1576b96... A > common/src/main/java/org/apache/sqoop/common/Direction.java > :000000 100644 0000000... d8d076c... A > common/src/main/java/org/apache/sqoop/common/DirectionError.java > :100644 100644 ed1de6e... 5069f0b... M > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java > :100644 100644 cb659ae... 91edcfc... M > common/src/main/java/org/apache/sqoop/json/JobBean.java > :100644 100644 86a49ea... eb1d741... M > common/src/main/java/org/apache/sqoop/json/JobValidationBean.java > :100644 100644 0b0b86a... 3c95da9... M > common/src/main/java/org/apache/sqoop/model/MConnector.java > :100644 100644 f561434... 813e8c1... M > common/src/main/java/org/apache/sqoop/model/MJob.java > :100644 100644 1473dba... 3790daa... M > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > :100644 100644 ca4b253... d17ebef... M > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java > :100644 100644 ac82284... 48360ea... M > core/src/main/java/org/apache/sqoop/framework/JobManager.java > :100644 100644 901937f... 30dc5b2... M > core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java > :100644 100644 3f12d0a... e9c32e0... M > core/src/main/java/org/apache/sqoop/repository/Repository.java > :100644 100644 791d27f... 92414d8... M > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java > :100644 100644 b4e9c2b... 8e31ef5... M > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java > :100644 100644 4bd7bce... e96909a... M > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java > :100644 100644 c3b6ae9... 6e2cfbf... M > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > :100644 100644 bed99a2... 01c32e4... M > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > :100644 100644 060a687... 3af84d7... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 473bb46... 6f2df93... M > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > :100644 100644 1b8f2b8... ed461ab... M > shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java > :100644 100644 9c558e2... 88afde3... M > shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java > :100644 100644 464f66e... 2fcd729... M > shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java > :100644 100644 9f5366d... 9fc9181... M > shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java > :100644 100644 1e15eb5... e04d7b5... M > shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java > :100644 100644 cc75d94... 9d63c6e... M > shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java > :100644 100644 40a4e33... 87c0776... M > shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java > :100644 100644 7081b4c... 2112bf7... M > spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java > :100644 100644 bdb6390... bfa6958... M > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java b42f234 > common/src/main/java/org/apache/sqoop/common/ConnectorType.java d3d1d19 > common/src/main/java/org/apache/sqoop/common/ConnectorTypeError.java > e61addf > common/src/main/java/org/apache/sqoop/common/Direction.java PRE-CREATION > common/src/main/java/org/apache/sqoop/common/DirectionError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java ed1de6e > common/src/main/java/org/apache/sqoop/json/JobBean.java cb659ae > common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 86a49ea > common/src/main/java/org/apache/sqoop/model/MConnector.java 0b0b86a > common/src/main/java/org/apache/sqoop/model/MJob.java f561434 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > 1473dba > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java ca4b253 > core/src/main/java/org/apache/sqoop/framework/JobManager.java ac82284 > core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java > 901937f > core/src/main/java/org/apache/sqoop/repository/Repository.java 3f12d0a > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java > 791d27f > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java > b4e9c2b > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java > 4bd7bce > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > c3b6ae9 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > bed99a2 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 060a687 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 473bb46 > shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 1b8f2b8 > shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java 9c558e2 > shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 464f66e > shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 9f5366d > shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java 1e15eb5 > shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java cc75d94 > shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java > 40a4e33 > spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java > 7081b4c > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > bdb6390 > > Diff: https://reviews.apache.org/r/24818/diff/ > > > Testing > ------- > > Manually executed xfer from mysql table to another mysql table. > > > Thanks, > > Abraham Elmahrek > >
