----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24879/#review51311 -----------------------------------------------------------
Thank you for the patch Richard! src/java/org/apache/sqoop/mapreduce/JobBase.java <https://reviews.apache.org/r/24879/#comment89492> Could you please use SqoopOptions.getHiveHome() instead? https://github.com/apache/sqoop/blob/trunk/src/java/org/apache/sqoop/SqoopOptions.java#L1303 src/java/org/apache/sqoop/mapreduce/JobBase.java <https://reviews.apache.org/r/24879/#comment89498> I don't think that throwing exception on missing HIVE_HOME is correct. What if the Hive libraries are already on our classpath because they have been added via different means (which would be the case when executed from Oozie). src/test/com/cloudera/sqoop/hive/TestHiveImport.java <https://reviews.apache.org/r/24879/#comment89497> This tests seems to be failing for me: 23226 [main] ERROR org.apache.sqoop.tool.ImportTool - Encountered IOException running import job: java.io.IOException: Cannot add hive libs as dependencies. at org.apache.sqoop.mapreduce.JobBase.cacheJars(JobBase.java:195) at org.apache.sqoop.mapreduce.ImportJobBase.runImport(ImportJobBase.java:243) at org.apache.sqoop.manager.SqlManager.importTable(SqlManager.java:665) at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:497) at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:605) at org.apache.sqoop.Sqoop.run(Sqoop.java:143) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:179) at com.cloudera.sqoop.Sqoop.runSqoop(Sqoop.java:45) at com.cloudera.sqoop.testutil.ImportJobTestCase.runImport(ImportJobTestCase.java:219) at com.cloudera.sqoop.hive.TestHiveImport.runImportTest(TestHiveImport.java:214) at com.cloudera.sqoop.hive.TestHiveImport.testNormalHiveImportAsParquet(TestHiveImport.java:278) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at junit.framework.TestCase.runTest(TestCase.java:176) at junit.framework.TestCase.runBare(TestCase.java:141) at junit.framework.TestResult$1.protect(TestResult.java:122) at junit.framework.TestResult.runProtected(TestResult.java:142) at junit.framework.TestResult.run(TestResult.java:125) at junit.framework.TestCase.run(TestCase.java:129) at junit.framework.TestSuite.runTest(TestSuite.java:255) at junit.framework.TestSuite.run(TestSuite.java:250) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:532) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1179) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:1030) I think that this is related to the commend I made above - throwing exception on missing HIVE_HOME doesn't seem as the right thing to do. Jarcec - Jarek Cecho On Aug. 20, 2014, 2:56 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24879/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 2:56 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1393 > https://issues.apache.org/jira/browse/SQOOP-1393 > > > Repository: sqoop-trunk > > > Description > ------- > > https://issues.apache.org/jira/browse/SQOOP-1393 > > > Diffs > ----- > > ivy.xml e5334f155d4e9f85053aff11281ede0e49518e27 > ivy/libraries.properties cbcbf0dd11ff50e4047d86629b5d3e40dd949654 > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java > 300406abcdbe6759ed65e22bfad7f7617ee693a3 > src/java/org/apache/sqoop/mapreduce/JobBase.java > 032d4086be16b1b67e71514e0270f4a03b24ed71 > src/java/org/apache/sqoop/tool/CodeGenTool.java > a6d5dff9800ecacd913cd4f2e5262147740f988e > src/java/org/apache/sqoop/tool/ImportTool.java > 54e618e583f72e5a5db5a852595eddb4a59394e5 > src/test/com/cloudera/sqoop/hive/TestHiveImport.java > 9c2a91c6efeeb21b85c04b7f8818aef84f23fd2a > testdata/hive/scripts/normalImportAsParquet.q PRE-CREATION > > Diff: https://reviews.apache.org/r/24879/diff/ > > > Testing > ------- > > testNormalHiveImportAsParquet() in TestHiveImport.java > > > Thanks, > > richard zhou > >
