----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25014/#review51367 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Aug. 24, 2014, 11:38 p.m., Chiwan Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25014/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2014, 11:38 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1330 > https://issues.apache.org/jira/browse/SQOOP-1330 > > > Repository: sqoop-trunk > > > Description > ------- > > I fixed a bug in code loading managers from property files. If some blank > newlines (or with line composed of only some spaces) occur in managers.d > property files, the new code just ignore them. > > > Diffs > ----- > > src/java/org/apache/sqoop/ConnFactory.java 2276525 > > Diff: https://reviews.apache.org/r/25014/diff/ > > > Testing > ------- > > * Manual Test on real cluster with following properties. > > > > com.cloudera.connector.teradata.TeradataManagerFactory=/usr/lib/sqoop-connector-teradata-1.2c5/sqoop-connector-teradata-1.2c5.jar > > com.quest.oraoop.OraOopManagerFactory=/usr/lib/oraoop.jar > > > Thanks, > > Chiwan Park > >
