----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25005/#review51417 -----------------------------------------------------------
+1 in general. Can you get rid of ConnectionValidationBean and JobValidationBean? Or perhaps in a follow up Jira? - Abraham Elmahrek On Aug. 23, 2014, 3:18 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25005/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2014, 3:18 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1466 > https://issues.apache.org/jira/browse/SQOOP-1466 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > Added enforcement code on the server side to execute the new validations and > send them back to client. > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 2b3171c > client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java > e0740a9 > client/src/main/java/org/apache/sqoop/client/request/JobRequest.java > b824512 > client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java > d87bb78 > common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/model/FormUtils.java d9666c8 > common/src/main/java/org/apache/sqoop/validation/ValidationResult.java > abe5b11 > common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java > 2721846 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > ff99f98 > > Diff: https://reviews.apache.org/r/25005/diff/ > > > Testing > ------- > > * New unit tests are passing > * Manual test on real cluster > > > Thanks, > > Jarek Cecho > >
