-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25074/
-----------------------------------------------------------
(Updated Aug. 26, 2014, 6:14 p.m.)
Review request for Sqoop, Abraham Elmahrek, Gwen Shapira, and Jarek Cecho.
Bugs: SQOOP-1436
https://issues.apache.org/jira/browse/SQOOP-1436
Repository: sqoop-sqoop2
Description
-------
https://issues.apache.org/jira/browse/SQOOP-1436
As discussed in the SQOOP-1436, this feature gives the ability to specifiy a
custom form name. It is optional, if given it is persisted in the metadata
repo. Methods that convert the form fields to JSON have also been modified to
read the custom form name attribute. basic validation for uniqueness, length
and pattern have been added
Existing unit tests modified to support the custom form name attribute
unit tests added for validation cases
Note: there are formatting changes since I used the mandated eclipse
formatter.xml in the IDE
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormUtils.java 27db8af
common/src/main/java/org/apache/sqoop/model/ModelError.java 1f466fe
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 08dfa7b
Diff: https://reviews.apache.org/r/25074/diff/
Testing
-------
mvn test and integration tests pass.
Thanks,
Veena Basavaraj
