----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25239/#review52016 -----------------------------------------------------------
Ship it! Please attach the patch to JIRA and I'll commit it. - Jarek Cecho On Sept. 2, 2014, 7:06 a.m., David Robson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25239/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 7:06 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1433 > https://issues.apache.org/jira/browse/SQOOP-1433 > > > Repository: sqoop-trunk > > > Description > ------- > > Turned off auto commit on Oracle connections. > Had to add a commit to one of the tests as it wasn't manually committing. > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/oracle/OracleConnectionFactory.java > 094576b > src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java 4546464 > src/test/org/apache/sqoop/manager/oracle/SystemImportTest.java 0f85854 > > Diff: https://reviews.apache.org/r/25239/diff/ > > > Testing > ------- > > Ran all automated tests for Oracle connector. > Manually tested some imports and exports. > > > Thanks, > > David Robson > >
