> On Sept. 4, 2014, 5:32 a.m., David Robson wrote: > > Hi Abe, > > > > I am not using CentOS 5 so can't comment on that side - but building the > > old documentation and the new one and comparing: > > > > In section "24.8.2.4. Supported Data Types" - there is now some headings in > > the table that don't make sense. There was no headings before - perhaps you > > can turn them off for these 2 tables? > > In section "24.8.6.6. Export Date And Timestamp Data Types into Oracle" - > > the heading hasn't worked properly - looks like there's another heading and > > the actual heading is coming out as the first row. > > In section "24.8.3.3. Connect to An Oracle RAC" the paragraph spacing > > hasn't been retained - although that's not a big deal just makes it a > > little harder to read. > > > > Other than that looks pretty much the same. > > > > David
Good eyes. On the paragraph spacing... it seems like it can be rectified by either adding more new lines between paragraphs or adding CSS that controls <tr> elements. There are only 9 elements that have "informaltable" class, so I've added some CSS to change the height. - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25324/#review52281 ----------------------------------------------------------- On Sept. 4, 2014, 9:51 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25324/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 9:51 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1490 > https://issues.apache.org/jira/browse/SQOOP-1490 > > > Repository: sqoop-trunk > > > Description > ------- > > Needed to remove new table syntax and use old table syntax > > > Diffs > ----- > > src/docs/user/connectors.txt 9aa2f44 > src/docs/web/docbook.css 4bef7dd > > Diff: https://reviews.apache.org/r/25324/diff/ > > > Testing > ------- > > built on top of CentOS 5.8 with asciidoc-8.1.0-1.el5 > > > Thanks, > > Abraham Elmahrek > >
