> On Sept. 5, 2014, 6:13 a.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java, line 91 > > <https://reviews.apache.org/r/25326/diff/1/?file=676400#file676400line91> > > > > Nit: Typo in the name "Arvo" should be "Avro" :) Fine to fix in follow > > up JIRA.
Filled SQOOP-1494. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25326/#review52289 ----------------------------------------------------------- On Sept. 4, 2014, 4:38 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25326/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 4:38 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1491 > https://issues.apache.org/jira/browse/SQOOP-1491 > > > Repository: sqoop-trunk > > > Description > ------- > > This is a patch to SQOOP-1395. As the entity class name is no longer > identical to the record name in Avro schema, there is not need to have > SqoopAvroRecord. The patch proposes to do two things: > 1. Remove SqoopAvroRecord (reverted ClassWriter to previous revision) > 2. Move common Avro handling code to AvtoUtil > > > Diffs > ----- > > src/java/org/apache/sqoop/avro/AvroUtil.java 4b37d58 > src/java/org/apache/sqoop/lib/SqoopAvroRecord.java 80875d2 > src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 6adad79 > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 905ba8c > src/java/org/apache/sqoop/mapreduce/ParquetImportMapper.java effbadd > src/java/org/apache/sqoop/mapreduce/ParquetJob.java a74432a > src/java/org/apache/sqoop/orm/ClassWriter.java 4f9dedd > > Diff: https://reviews.apache.org/r/25326/diff/ > > > Testing > ------- > > All unittests passed. No new unittest added. > Manually tested couple of import tests. > > > Thanks, > > Qian Xu > >
