----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25374/#review52423 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Sept. 5, 2014, 6:53 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25374/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 6:53 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1492 > https://issues.apache.org/jira/browse/SQOOP-1492 > > > Repository: sqoop-trunk > > > Description > ------- > > As the Parquet support and Avro support are very similar. We'd suggest move > out Avro and GenericRecord related common code from Avro exporter to AvroUtil > and GenericRecord. > > > Diffs > ----- > > src/java/org/apache/sqoop/avro/AvroUtil.java 811c240 > src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java 1f0cb6a > src/java/org/apache/sqoop/mapreduce/GenericRecordExportMapper.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25374/diff/ > > > Testing > ------- > > All existing unittest passed. No additional unittests added. > > > Thanks, > > Qian Xu > >
