> On Aug. 28, 2014, 12:31 a.m., Venkat Ranganathan wrote: > >
Venkat, thanks for doing a thorough review. I am sorry, I could not get back with my reply sooner. I have to do extensive documentation updates. They are still not perfect due to inherent assumption everywhere that input comes from only a DB table. I have uploaded the latest patch file that has all changes not just incremental changes from previous version of the patch. Please let me know whether that is okay. > On Aug. 28, 2014, 12:31 a.m., Venkat Ranganathan wrote: > > src/docs/man/common-args.txt, line 24 > > <https://reviews.apache.org/r/22516/diff/2/?file=670447#file670447line24> > > > > I see - you want to remove DB specific args from this and only use it > > for import specifc. Don't we need this option in other Sqoop tools (like > > export, eval, list-databases etc I have fixed this by creating database-independent-args.txt which describes arguments that are independent of database input. For other tools, the DB specific arguments will be exposed in the documentation. > On Aug. 28, 2014, 12:31 a.m., Venkat Ranganathan wrote: > > src/docs/man/database-connection-args.txt, line 10 > > <https://reviews.apache.org/r/22516/diff/2/?file=670448#file670448line10> > > > > Trailing space Removed. > On Aug. 28, 2014, 12:31 a.m., Venkat Ranganathan wrote: > > src/docs/man/import-args.txt, line 35 > > <https://reviews.apache.org/r/22516/diff/2/?file=670449#file670449line35> > > > > Intended? I modified this since mainframe import tool will support importing to anything that sqoop-import supports. > On Aug. 28, 2014, 12:31 a.m., Venkat Ranganathan wrote: > > src/docs/man/import-args.txt, line 56 > > <https://reviews.apache.org/r/22516/diff/2/?file=670449#file670449line56> > > > > I think a few of the options have been removed. Are you moving it into > > another guide. I have not removed any args. Please look at the latest version. > On Aug. 28, 2014, 12:31 a.m., Venkat Ranganathan wrote: > > src/docs/user/import.txt, line 212 > > <https://reviews.apache.org/r/22516/diff/2/?file=670461#file670461line212> > > > > Not sure why we need to move this into a new file Chunk of documentation on distributed cache is common and so I moved to a separate file. - Mariappan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22516/#review51725 ----------------------------------------------------------- On Aug. 27, 2014, 7:55 p.m., Mariappan Asokan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22516/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 7:55 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > This is to move mainframe datasets to Hadoop. > > > Diffs > ----- > > ivy.xml 6335e01 > ivy/libraries.properties 6818b3e > src/docs/man/common-args.txt e8d1f17 > src/docs/man/database-connection-args.txt PRE-CREATION > src/docs/man/import-args.txt 2bb69ba > src/docs/man/import-common-args.txt PRE-CREATION > src/docs/man/mainframe-connection-args.txt PRE-CREATION > src/docs/man/sqoop-import-mainframe.txt PRE-CREATION > src/docs/man/sqoop-import.txt 00b1ec8 > src/docs/man/sqoop.txt febe827 > src/docs/user/SqoopUserGuide.txt 2e88887 > src/docs/user/basics.txt 7e5a76a > src/docs/user/connecting-to-mainframe.txt PRE-CREATION > src/docs/user/distributed-cache.txt PRE-CREATION > src/docs/user/import-mainframe-purpose.txt PRE-CREATION > src/docs/user/import-mainframe.txt PRE-CREATION > src/docs/user/import.txt c5ffa50 > src/docs/user/intro.txt 99cd475 > src/docs/user/mainframe-common-args.txt PRE-CREATION > src/docs/user/tools.txt 7d977d4 > src/docs/user/validation-args.txt 3cb5f66 > src/java/org/apache/sqoop/SqoopOptions.java 3ef5a97 > src/java/org/apache/sqoop/manager/MainframeManager.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetInputFormat.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetInputSplit.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetRecordReader.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java > PRE-CREATION > src/java/org/apache/sqoop/tool/MainframeImportTool.java PRE-CREATION > src/java/org/apache/sqoop/tool/SqoopTool.java dbe429a > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java PRE-CREATION > src/test/org/apache/sqoop/manager/TestMainframeManager.java PRE-CREATION > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java > PRE-CREATION > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetInputFormat.java > PRE-CREATION > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetInputSplit.java > PRE-CREATION > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java > PRE-CREATION > src/test/org/apache/sqoop/tool/TestMainframeImportTool.java PRE-CREATION > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22516/diff/ > > > Testing > ------- > > > Thanks, > > Mariappan Asokan > >
