-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25786/
-----------------------------------------------------------
(Updated Sept. 19, 2014, 9:35 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1497
https://issues.apache.org/jira/browse/SQOOP-1497
Repository: sqoop-SQOOP-1367
Description (updated)
-------
I could not avoid it, it did become a huge RB since I renamed the following
entities.
MConnection -MLink
MFramework - MDriverConfig
FrameworkManager - Driver ( the main class that encapsulates the driver config
+ other related things of loading configs etc)
Metadata removed ( consistently use Repository)
- renamed request to resource requests to differentiate it from the internal
job/submission requests created in job manager
- removed the framework security form since it is not used anywhere.
Short link to review multiple pages :
https://reviews.apache.org/r/25786/diff/?page=2
This RB "does not have"
- any functional changes
- Forms renames to configs ( another RB)
- does not have api changes, even though the resources have been renamed.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 0e45a24
client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java
8436fc5
client/src/main/java/org/apache/sqoop/client/request/ConnectorRequest.java
876099c
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java
PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java
PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/FrameworkRequest.java
06f9006
client/src/main/java/org/apache/sqoop/client/request/JobRequest.java e520883
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java
PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java
PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/Request.java d9229f5
client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
0d13304
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java
PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
bafb30f
client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java
PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/VersionRequest.java
2b236ba
client/src/main/java/org/apache/sqoop/client/request/VersionResourceRequest.java
PRE-CREATION
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 731f6cc
common/src/main/java/org/apache/sqoop/common/SqoopException.java 98f9dc7
common/src/main/java/org/apache/sqoop/etl/io/DataReader.java a34dfb4
common/src/main/java/org/apache/sqoop/json/ConnectionBean.java 688bb64
common/src/main/java/org/apache/sqoop/json/ConnectionValidationBean.java
ffdd13e
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 5069f0b
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/FrameworkBean.java abbdcc6
common/src/main/java/org/apache/sqoop/json/JobBean.java 91edcfc
common/src/main/java/org/apache/sqoop/json/LinkBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
9558941
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java
9f3ad62
common/src/main/java/org/apache/sqoop/model/MConnection.java f84abbf
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MFramework.java 580db9c
common/src/main/java/org/apache/sqoop/model/MInput.java 1f4c425
common/src/main/java/org/apache/sqoop/model/MJob.java 182bbfb
common/src/main/java/org/apache/sqoop/model/MLink.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 19f81a8
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java
PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java 5cc110a
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 3106d39
common/src/test/java/org/apache/sqoop/json/TestUtil.java a9aa233
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java c6086dd
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
f3d4166
common/src/test/java/org/apache/sqoop/model/TestMConnection.java 27959fb
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java
PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMFramework.java 5273a90
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
3790daa
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorMetadataUpgrader.java
cbe72f6
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java
PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java
9915603
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java
2df193c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
87e0862
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java
07ae988
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java
a25f344
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java
4ba278e
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
73a49b1
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
0a60e90
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java
6061600
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionForm.java
3b5d70a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java
64e9a9a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobForm.java
PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromTableForm.java
72902a2
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java
PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkForm.java
PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java
9215e6c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobForm.java
PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToTableForm.java
642da11
connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
a1302c0
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java
2b1dec2
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
2d07130
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java
d7e8c6c
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java
f1023c8
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
eb6fcf1
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
883636c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
7447071
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
61676fe
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsMetadataUpgrader.java
3e51e38
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java
df764d2
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java
4efbd33
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ConnectionConfiguration.java
6dd79d5
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ConnectionForm.java
7dad2a2
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java
bccb99d
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobForm.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/InputForm.java
413f04c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkForm.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/OutputCompression.java
55db1bc
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/OutputForm.java
d57b4c2
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/OutputFormat.java
676c33c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToCompression.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToFormat.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java
65ee8a7
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobForm.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/hdfsWriter/HdfsSequenceWriter.java
eb80121
connector/connector-hdfs/src/main/resources/hdfs-connector-resources.properties
3125911
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
5e21543
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
79cf1f1
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java
ae93b0a
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java
91b594e
core/src/main/configs/driver-config.properties PRE-CREATION
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 8782209
core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 898ec73
core/src/main/java/org/apache/sqoop/core/SqoopServer.java d4c3b39
core/src/main/java/org/apache/sqoop/driver/Driver.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverConstants.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverError.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/ExecutionEngine.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/JobManager.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/SubmissionRequest.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ConnectionConfiguration.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/framework/ExecutionEngine.java 96ec148
core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java 4293dce
core/src/main/java/org/apache/sqoop/framework/FrameworkError.java 8ecb197
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 81e1147
core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java
2437fa6
core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java 46257f2
core/src/main/java/org/apache/sqoop/framework/JobManager.java b1b37f6
core/src/main/java/org/apache/sqoop/framework/SubmissionEngine.java 3c0f6eb
core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java bf3f785
core/src/main/java/org/apache/sqoop/framework/configuration/ConnectionConfiguration.java
897d3c7
core/src/main/java/org/apache/sqoop/framework/configuration/JobConfiguration.java
0abc611
core/src/main/java/org/apache/sqoop/framework/configuration/SecurityForm.java
8ab50ed
core/src/main/java/org/apache/sqoop/framework/configuration/ThrottlingForm.java
c435f6b
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java fa119a5
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
4de3134
core/src/main/java/org/apache/sqoop/repository/Repository.java 8e8dd80
core/src/main/resources/framework-resources.properties 7ecb9ae
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java
PRE-CREATION
core/src/test/java/org/apache/sqoop/driver/TestSubmissionRequest.java
PRE-CREATION
core/src/test/java/org/apache/sqoop/framework/TestFrameworkMetadataUpgrader.java
81d197e
core/src/test/java/org/apache/sqoop/framework/TestFrameworkValidator.java
69c1b56
core/src/test/java/org/apache/sqoop/framework/TestSubmissionRequest.java
3078ed2
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
50daa62
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MRSubmissionRequest.java
32d598c
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java
b05954b
execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java
4cdb002
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java
fdcecf2
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
68aea9c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
29da340
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
f9e9217
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
745e128
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java
PRE-CREATION
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestFrameworkHandling.java
006ec9c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
15f9539
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java
913439b
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
e658c11
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
PRE-CREATION
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java
8fce0dd
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
89ad3ec
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java
PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
616e974
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java e2fc86c
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
6e21dd9
server/src/main/java/org/apache/sqoop/server/v1/ConnectionServlet.java
e8af4d7
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java
PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/FrameworkServlet.java 9c99731
server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 34a0ffb
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java
7252e11
shell/src/main/java/org/apache/sqoop/shell/CloneCommand.java 4cdf0e4
shell/src/main/java/org/apache/sqoop/shell/CloneConnectionFunction.java
d912c1c
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java ed461ab
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java fce7c86
shell/src/main/java/org/apache/sqoop/shell/CreateConnectionFunction.java
92a8aa5
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java 88afde3
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunciton.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 107e5e0
shell/src/main/java/org/apache/sqoop/shell/DeleteConnectionFunction.java
1eb7e51
shell/src/main/java/org/apache/sqoop/shell/DeleteLinkFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/DisableCommand.java fa3263f
shell/src/main/java/org/apache/sqoop/shell/DisableConnectionFunction.java
816ff75
shell/src/main/java/org/apache/sqoop/shell/DisableLinkFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/EnableCommand.java b48647b
shell/src/main/java/org/apache/sqoop/shell/EnableConnectionFunction.java
174c3df
shell/src/main/java/org/apache/sqoop/shell/EnableLinkFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java ba1d384
shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java
b6cf403
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java bbfbb3f
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShowFrameworkFunction.java 0c587b2
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 2fcd729
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java 6cb28e5
shell/src/main/java/org/apache/sqoop/shell/UpdateCommand.java d291c42
shell/src/main/java/org/apache/sqoop/shell/UpdateConnectionFunction.java
405b0ea
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 9fc9181
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java efabc46
shell/src/main/java/org/apache/sqoop/shell/utils/ConnectionDynamicFormOptions.java
6b6e858
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java
cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java bbad183
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java bbf7af7
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java
PRE-CREATION
shell/src/main/resources/shell-resource.properties 73a19e8
spi/src/main/java/org/apache/sqoop/connector/spi/MetadataUpgrader.java
328f9b0
spi/src/main/java/org/apache/sqoop/connector/spi/RespositoryUpgrader.java
PRE-CREATION
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 2774e8b
spi/src/main/java/org/apache/sqoop/validation/Validator.java 9b791f8
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
bfa6958
test/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.java e0cc7c9
test/src/main/java/org/apache/sqoop/test/db/DatabaseProviderFactory.java
bc430f1
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
8a699f5
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java
7e2558f
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java
c01aa80
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java
f976f29
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
fac7e8b
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java
cb782c7
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
3c01cb0
test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java
cea24b9
tools/src/main/java/org/apache/sqoop/tools/tool/UpgradeTool.java b8a15cb
Diff: https://reviews.apache.org/r/25786/diff/
Testing
-------
mvn test and integration test.
running sqoop client pending
Thanks,
Veena Basavaraj
