[
https://issues.apache.org/jira/browse/SQOOP-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141490#comment-14141490
]
Veena Basavaraj edited comment on SQOOP-1402 at 9/19/14 11:05 PM:
------------------------------------------------------------------
+ 1
It is true for all other constants too, and the tests dont share these values,
instead they hard code them, so any kind of refactoring leads to issues with
tests
was (Author: vybs):
+ 1
> SQOOP2: Move all JSON constants to a single final class
> -------------------------------------------------------
>
> Key: SQOOP-1402
> URL: https://issues.apache.org/jira/browse/SQOOP-1402
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Gwen Shapira
>
> JSON constants (i.e. field names) are currently defined all over the place.
> This leads to duplication, and if we ever decide to rename something it will
> be a mess.
> I suggest adding a constants class to org.apache.sqoop.json and have everyone
> use the same constants.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
