[
https://issues.apache.org/jira/browse/SQOOP-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142921#comment-14142921
]
Chiwan Park commented on SQOOP-1478:
------------------------------------
I have a problem to upgrade junit3 to junit4. Assert.assertEquals(double,
double) is deprecated. To use new assertEquals, we decide epsilon value for
comparison. (Assert.assertEquals(double, double, epsilon))
Following message is surefire report.
{code}
-------------------------------------------------------------------------------
Test set: org.apache.sqoop.json.TestSubmissionBean
-------------------------------------------------------------------------------
Tests run: 15, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.088 sec <<<
FAILURE!
testTransferProgress(org.apache.sqoop.json.TestSubmissionBean) Time elapsed:
0.005 sec <<< FAILURE!
java.lang.AssertionError: Use assertEquals(expected, actual, delta) to compare
floating-point numbers
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertEquals(Assert.java:576)
at org.junit.Assert.assertEquals(Assert.java:565)
at
org.apache.sqoop.json.TestSubmissionBean.testTransferProgress(TestSubmissionBean.java:298)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
{code}
What is best value of epsilon to compare double value?
> Sqoop2: Migrate remaining tests from junit 3 to 4
> -------------------------------------------------
>
> Key: SQOOP-1478
> URL: https://issues.apache.org/jira/browse/SQOOP-1478
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Jarek Jarcec Cecho
> Labels: newbie
> Fix For: 2.0.0, from/to
>
>
> It seems that we still have some tests that are using junit 3 imports:
> {code}
> jarcec@arlene sqoop2 % ack "junit.framework" | wc -l
> 27
> {code}
> We should convert them to junit 4 (and package {{org.junit}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
