----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25975/#review54381 -----------------------------------------------------------
Abe, All these files will change with my refactoring to config objects. is it ok if we dont commit this? - Veena Basavaraj On Sept. 23, 2014, 6:15 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25975/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 6:15 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1418 > https://issues.apache.org/jira/browse/SQOOP-1418 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit b7d9f2536c850d623aa34f0037bc8e29bfe151dd > Author: Abraham Elmahrek <[email protected]> > Date: Tue Sep 23 17:34:11 2014 -0700 > > SQOOP-1418: Sqoop2: From/To: Remove MJobForms > > :100644 100644 54ea3d2... 779eb76... M > client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java > :100644 100644 465dd69... 833bae2... M > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java > :100644 100644 a2cc8b8... b490f6b... M > common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java > :100644 100644 a3e6071... c8c06dc... M > common/src/main/java/org/apache/sqoop/json/JobBean.java > :100644 100644 3dc1014... c617758... M > common/src/main/java/org/apache/sqoop/model/MConnector.java > :100644 100644 62eb197... 4bfa9e4... M > common/src/main/java/org/apache/sqoop/model/MDriverConfig.java > :100644 100644 c9b45a5... bff06bc... M > common/src/main/java/org/apache/sqoop/model/MJob.java > :100644 000000 08b9a78... 0000000... D > common/src/main/java/org/apache/sqoop/model/MJobForms.java > :100644 100644 eaf9122... c40289d... M > common/src/test/java/org/apache/sqoop/json/TestUtil.java > :100644 100644 3fde47b... 95f90fc... M > common/src/test/java/org/apache/sqoop/model/TestMConnector.java > :100644 100644 9c23cc3... c4a8a9d... M > common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java > :100644 100644 96c316a... 4f4bd96... M > common/src/test/java/org/apache/sqoop/model/TestMJob.java > :100644 000000 81a8614... 0000000... D > common/src/test/java/org/apache/sqoop/model/TestMJobForms.java > :100644 100644 8deddb0... b29ebab... M > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java > :100644 100644 47b186c... cd824c2... M > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java > :100644 100644 346b625... 6ab902f... M > connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java > :100644 100644 dbfdc03... 9c72262... M > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java > :100644 100644 5297bde... 1ab7c9b... M > core/src/main/java/org/apache/sqoop/driver/Driver.java > :100644 100644 8d6eb78... c8a1729... M > core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java > :100644 100644 ea1608a... 79b7212... M > core/src/main/java/org/apache/sqoop/repository/Repository.java > :100644 100644 9c39d23... cd79a24... M > core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java > :100644 100644 796b021... 1841610... M > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > :100644 100644 5dd7970... 60a0c5e... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 998f5b7... 400f618... M > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > :100644 100644 b61d3f5... 0eb51e8... M > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > :100644 100644 e00b404... 7194904... M > spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java > > > Diffs > ----- > > client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2 > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 465dd69 > common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8 > common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071 > common/src/main/java/org/apache/sqoop/model/MConnector.java 3dc1014 > common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197 > common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5 > common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78 > common/src/test/java/org/apache/sqoop/json/TestUtil.java eaf9122 > common/src/test/java/org/apache/sqoop/model/TestMConnector.java 3fde47b > common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3 > common/src/test/java/org/apache/sqoop/model/TestMJob.java 96c316a > common/src/test/java/org/apache/sqoop/model/TestMJobForms.java 81a8614 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java > 8deddb0 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java > 47b186c > > connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java > 346b625 > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03 > core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde > core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java > 8d6eb78 > core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a > core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java > 9c39d23 > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > 796b021 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 5dd7970 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > 998f5b7 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > b61d3f5 > spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java > e00b404 > > Diff: https://reviews.apache.org/r/25975/diff/ > > > Testing > ------- > > mvn clean verify > > Ran basic import from MySQL to HDFS test > > > Thanks, > > Abraham Elmahrek > >
