> On Sept. 24, 2014, 10:32 p.m., Gwen Shapira wrote: > > Silly question, but it looks like this patch only handles job forms. What > > about connection forms? > > Abraham Elmahrek wrote: > Job forms should only be null if that direction is not supported. It > could contain an empty list.
oh! got it :) - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26006/#review54467 ----------------------------------------------------------- On Sept. 24, 2014, 10:10 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26006/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 10:10 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1542 > https://issues.apache.org/jira/browse/SQOOP-1542 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit c0ce10e3b2ea0d680eb06e9cc58190cf0a72dbe0 > Author: Abraham Elmahrek <[email protected]> > Date: Wed Sep 24 14:21:08 2014 -0700 > > SQOOP-1542: Sqoop2: From/To: MConnector should handle null forms > > :100644 100644 3dc1014... 7999b08... M > common/src/main/java/org/apache/sqoop/model/MConnector.java > :100644 100644 3fde47b... 0a5fd90... M > common/src/test/java/org/apache/sqoop/model/TestMConnector.java > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/model/MConnector.java 3dc1014 > common/src/test/java/org/apache/sqoop/model/TestMConnector.java 3fde47b > > Diff: https://reviews.apache.org/r/26006/diff/ > > > Testing > ------- > > mvn clean verify > > > Thanks, > > Abraham Elmahrek > >
