----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25180/#review54595 -----------------------------------------------------------
common/src/main/java/org/apache/sqoop/model/MSubmission.java <https://reviews.apache.org/r/25180/#comment94779> can be empty should be elaborated common/src/main/java/org/apache/sqoop/model/MSubmission.java <https://reviews.apache.org/r/25180/#comment94775> requires but can be empty? can we reword it? soft required, if empty we default to something ? common/src/main/java/org/apache/sqoop/schema/Schema.java <https://reviews.apache.org/r/25180/#comment94776> knitpick: please format common/src/main/java/org/apache/sqoop/schema/SchemaError.java <https://reviews.apache.org/r/25180/#comment94778> I suggest we kepe naming consistent across the code base to from/to if we are naming FromSchema and ToSchema Since there are error messages to the developer, consistency will be useful connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorError.java <https://reviews.apache.org/r/25180/#comment94780> is not this direction type? connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java <https://reviews.apache.org/r/25180/#comment94781> my bad, can be rename this to linkConf? I missed it in the last RB connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java <https://reviews.apache.org/r/25180/#comment94782> is this null check necessary? connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java <https://reviews.apache.org/r/25180/#comment94783> reading - extract writitng - load to keep the ETL consistency in javadoc connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/LocationMatcher.java <https://reviews.apache.org/r/25180/#comment94785> nice! But I still think Position is better representation than location execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java <https://reviews.apache.org/r/25180/#comment94784> may be FROM_SCHEMA_CONNECTOR_KEY - Veena Basavaraj On Sept. 24, 2014, 6:36 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25180/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 6:36 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > SQOOP-1378 - Sqoop2: From/To: Refactor schema > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java fd73890 > common/src/main/java/org/apache/sqoop/json/SchemaBean.java 468f7ee > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 9b1ae74 > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > f6a9bbf > common/src/main/java/org/apache/sqoop/model/MSubmission.java ca21135 > common/src/main/java/org/apache/sqoop/schema/Schema.java bbebab8 > common/src/main/java/org/apache/sqoop/schema/SchemaError.java 7c8c61e > common/src/main/java/org/apache/sqoop/schema/SchemaMatchOption.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/schema/type/Column.java 30c26a3 > > common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java > ab5bbd4 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > 9d0c178 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > 776359a > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java > 70833a0 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorError.java > 8a095d2 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java > 923f904 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java > 7942d59 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > df5cb9c > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > 74b9518 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/AbstractMatcher.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/LocationMatcher.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/NameMatcher.java > PRE-CREATION > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 8c83a71 > core/src/main/java/org/apache/sqoop/driver/JobManager.java 277c6be > docs/src/site/sphinx/Tools.rst ad72cd1 > execution/.DS_Store PRE-CREATION > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java > 2ed06a8 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > 6680f60 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > eea0623 > shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java > 60acfb6 > shell/src/main/resources/shell-resource.properties b59bd81 > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > fe92ac4 > > Diff: https://reviews.apache.org/r/25180/diff/ > > > Testing > ------- > > Added unit tests and did manual testing: > Hdfs->MySQL > MySQL->Hdfs > MySQL->MySQL (name based matching) > > > Thanks, > > Gwen Shapira > >
