> On Oct. 2, 2014, 4:47 p.m., Gwen Shapira wrote: > > Ship It! > > Gwen Shapira wrote: > Looks awesome. I wish I thought of this design myself. > > One possible cleanup: Make getMatchingData take IDF as input and return > IDF as output (or maybe even initialize with the IDFs and not schemas?). This > will allow cleaning up the part in SqoopMapper where you need two IDFs and > looks a bit weird. Can be done later, or even never. > > Abraham Elmahrek wrote: > This is a great idea IMO. Let's do it in a follow up Jira then!
https://issues.apache.org/jira/browse/SQOOP-1564 - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26265/#review55215 ----------------------------------------------------------- On Oct. 2, 2014, 9:52 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26265/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 9:52 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1560 > https://issues.apache.org/jira/browse/SQOOP-1560 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit 79708d22c38df8c68c64724c622114c2d874cdec > Author: Abraham Elmahrek <[email protected]> > Date: Thu Sep 25 19:51:10 2014 -0700 > > SQOOP-1560: Sqoop2: Move matcher out of Schema > > :100644 100644 2a49221... d6bad87... M > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > :100644 100644 d98b779... 5ef6fc6... M > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > :100644 000000 e6b2316... 0000000... D > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/AbstractMatcher.java > :100644 000000 938a5df... 0000000... D > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/LocationMatcher.java > :100644 000000 417c85b... 0000000... D > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/NameMatcher.java > :000000 100644 0000000... 58b709e... A > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > :000000 100644 0000000... 8ab1318... A > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > :000000 100644 0000000... 577b091... A > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java > :000000 100644 0000000... ae89e6c... A > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherFactory.java > :000000 100644 0000000... 69d5ebd... A > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > :100644 100644 3954039... 765bedd... M > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > :100644 100644 8c88d52... 03d84d4... M > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > :100644 100644 941b31d... 1ebd3e4... M > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > :100644 100644 b5435ff... 1952cbb... M > execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java > :100644 100644 5662120... 032cc11... M > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > :000000 100644 0000000... 7f9a147... A > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > 2a49221 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > d98b779 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/AbstractMatcher.java > e6b2316 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/LocationMatcher.java > 938a5df > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/NameMatcher.java > 417c85b > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherFactory.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > PRE-CREATION > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 3954039 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > 8c88d52 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > 941b31d > execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java > b5435ff > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > 5662120 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/26265/diff/ > > > Testing > ------- > > mvn clean verify > > > Thanks, > > Abraham Elmahrek > >
