[ 
https://issues.apache.org/jira/browse/SQOOP-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166334#comment-14166334
 ] 

Hudson commented on SQOOP-1498:
-------------------------------

FAILURE: Integrated in Sqoop2-hadoop100 #613 (See 
[https://builds.apache.org/job/Sqoop2-hadoop100/613/])
SQOOP-1498: Sqoop2: Repository Object refactoring (objects prefixed with M) 
(abraham: 
https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8362c73cc01313d2510a659bf296efd727bb1d4e)
* spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java
* 
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java
* common/src/main/java/org/apache/sqoop/model/MConfigType.java
* shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java
* client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java
* spi/src/main/java/org/apache/sqoop/job/etl/Loader.java
* core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java
* common/src/main/java/org/apache/sqoop/model/MJobForms.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java
* core/src/main/java/org/apache/sqoop/driver/JobManager.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
* common/src/test/java/org/apache/sqoop/model/TestMFormList.java
* shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java
* 
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java
* 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
* 
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java
* shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java
* common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java
* common/src/main/java/org/apache/sqoop/model/MDriverConfig.java
* common/src/main/java/org/apache/sqoop/model/MFromConfig.java
* spi/src/main/java/org/apache/sqoop/validation/Validator.java
* common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java
* common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java
* 
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
* common/src/main/java/org/apache/sqoop/model/MLinkConfig.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java
* server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
* connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
* 
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java
* 
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java
* core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java
* shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
* common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
* 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java
* common/src/main/java/org/apache/sqoop/model/MFormList.java
* common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java
* core/src/main/java/org/apache/sqoop/repository/Repository.java
* 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java
* client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java
* core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
* 
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
* execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java
* common/src/main/java/org/apache/sqoop/json/JobBean.java
* 
connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties
* 
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java
* shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java
* shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java
* common/src/main/java/org/apache/sqoop/model/ConfigClass.java
* shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java
* common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java
* common/src/main/java/org/apache/sqoop/utils/ClassUtils.java
* 
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java
* 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
* common/src/main/java/org/apache/sqoop/validation/Validation.java
* core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java
* core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
* shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
* common/src/main/java/org/apache/sqoop/model/MLink.java
* 
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
* shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java
* common/src/main/java/org/apache/sqoop/validation/ValidationError.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
* common/src/main/java/org/apache/sqoop/model/FormUtils.java
* core/src/main/resources/driver-config.properties
* shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java
* server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
* common/src/test/java/org/apache/sqoop/model/TestMConnector.java
* common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java
* core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java
* common/src/main/java/org/apache/sqoop/model/MForm.java
* core/src/main/java/org/apache/sqoop/driver/DriverValidator.java
* shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java
* 
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java
* common/src/test/java/org/apache/sqoop/model/TestMForm.java
* common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java
* execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java
* core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java
* common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java
* common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
* common/src/test/java/org/apache/sqoop/model/TestMJobForms.java
* shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java
* common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java
* common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java
* client/src/main/java/org/apache/sqoop/client/SqoopClient.java
* common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java
* shell/src/main/java/org/apache/sqoop/shell/ShowDriverFunction.java
* 
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java
* 
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
* common/src/test/java/org/apache/sqoop/json/TestDriverBean.java
* 
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
* common/src/test/java/org/apache/sqoop/model/TestMJob.java
* shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java
* common/src/test/java/org/apache/sqoop/model/TestFormUtils.java
* core/src/main/java/org/apache/sqoop/driver/JobRequest.java
* common/src/test/java/org/apache/sqoop/json/TestValidationBean.java
* common/src/main/java/org/apache/sqoop/validation/ValidationResult.java
* shell/src/main/resources/shell-resource.properties
* common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java
* common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java
* common/src/main/java/org/apache/sqoop/json/LinkBean.java
* common/src/main/java/org/apache/sqoop/model/ModelError.java
* 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java
* spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java
* common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
* core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java
* common/src/test/java/org/apache/sqoop/json/TestUtil.java
* 
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
* common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java
* common/src/main/java/org/apache/sqoop/model/MConfig.java
* common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java
* shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java
* 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java
* 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
* spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java
* common/src/test/java/org/apache/sqoop/model/TestMConfig.java
* common/src/test/java/org/apache/sqoop/validation/TestValidation.java
* test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
* execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java
* shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java
* common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java
* common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java
* 
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java
* spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java
* common/src/main/java/org/apache/sqoop/json/ThrowableBean.java
* core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
* shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
* common/src/main/java/org/apache/sqoop/model/MToConfig.java
* common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java
* common/src/main/java/org/apache/sqoop/model/MDriver.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
* common/src/main/java/org/apache/sqoop/json/DriverBean.java
* 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java
* 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java
* shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java
* spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java
* 
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
* common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java
* common/src/main/java/org/apache/sqoop/model/MJob.java
* server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java
* core/src/main/java/org/apache/sqoop/driver/Driver.java
* common/src/main/java/org/apache/sqoop/json/JobValidationBean.java
* spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
* shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java
* 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java
* common/src/main/java/org/apache/sqoop/model/MFormType.java
* shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java
* 
common/src/test/java/org/apache/sqoop/validation/validators/TestClassAvailable.java
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java
* core/src/test/java/org/apache/sqoop/driver/TestJobManager.java
* common/src/main/java/org/apache/sqoop/model/Form.java
* core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
* shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
* common/src/main/java/org/apache/sqoop/validation/Message.java
* shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java
* common/src/test/java/org/apache/sqoop/model/TestMConfigList.java
* common/src/test/java/org/apache/sqoop/model/TestMDriver.java
* shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java
* test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java
* common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java
* core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
* common/src/test/java/org/apache/sqoop/model/TestMLink.java
* core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java
* common/src/test/java/org/apache/sqoop/json/TestLinkBean.java
* common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
* common/src/main/java/org/apache/sqoop/model/Config.java
* shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java
* common/src/main/java/org/apache/sqoop/model/MConfigList.java
* common/src/main/java/org/apache/sqoop/model/ConfigUtils.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
* common/src/test/java/org/apache/sqoop/json/TestJobBean.java
* client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java
* common/src/main/java/org/apache/sqoop/model/FormClass.java
* shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java
* common/src/main/java/org/apache/sqoop/model/MConnectionForms.java
* server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
* common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java
* common/src/main/java/org/apache/sqoop/model/MConnector.java
* shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java


> Sqoop2: Repository Object refactoring ( objects prefixed with M)
> ----------------------------------------------------------------
>
>                 Key: SQOOP-1498
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1498
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: from/to
>
>         Attachments: SQOOP-1498final.patch, 
> SQOOP-1498finalwithoutgitignore.patch, Sqoop2.pdf
>
>
> See the attached PDF.
> Currently there is a lot of overlap with the entity model classes. All the 
> entity model classes in the code are are prefixed with "M" and are under the 
> org.apache.sqoop.model package. 
> The proposed refactoring will do the following things.
> No more MConnectionForms and MJobForms 
> MConfig( abstract)
> FromConfig ( may or may not inherit MConfigList). Still debating if we need a 
> conflg list. We can use a group attribute on the inputs if we need add 
> hierarchy to the config inputs
> ToConfig
> DriverConfig
> FromConfig/ToConfig/DriverConfig entities belongs to a MJob
> MInput (MConfig has one or more MInputs)
> MConnector will be pretty dumb and will hold its 3 config objects, 
> LinkConfig. FromConfig and ToConfig 
> MLink belongs to a MConnector
> MLink will have a reference to connector and the link config. There will be 
> no connector/ framework part.
> MSubmisssion  belongs to a MJob 
> Lastly, the Repository schema will also be renamed to reflect the 
> context/link/driver/jobrun changes
> End of Story!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to