----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26539/#review56231 -----------------------------------------------------------
The patch looks good. I'm just confused about the location of the package. Looks like the old validators were part of the spi and the new are in common. Why did we move them? I thought they made a lot of sense in the spi. - Gwen Shapira On Oct. 10, 2014, 2:57 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26539/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 2:57 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1575 > https://issues.apache.org/jira/browse/SQOOP-1575 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > I've provided new validators into HDFS connector configuration objects. I'm > pretty much re-implementing what is available in the old validator. > > > Diffs > ----- > > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java > 037fe59 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java > 2dfd738 > > Diff: https://reviews.apache.org/r/26539/diff/ > > > Testing > ------- > > Tested on real cluster, seems to be working just fine. > > > Thanks, > > Jarek Cecho > >
