> On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote: > > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 57-58 > > <https://reviews.apache.org/r/27095/diff/5/?file=731689#file731689line57> > > > > Hyphenated case (if there is such a thing)?
sorry I did not get it. It is pretty much a practice not to use hyphens in JSON values, I have seen here the first. > On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote: > > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, line 88 > > <https://reviews.apache.org/r/27095/diff/5/?file=731689#file731689line88> > > > > Shouldn't this vary by API? > > > > For example, /connectors/ => CONNECTORS and /connectors/1/ => CONNECTOR. yes it does, hence so > On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote: > > common/src/main/java/org/apache/sqoop/json/JsonBean.java, line 26 > > <https://reviews.apache.org/r/27095/diff/5/?file=731692#file731692line26> > > > > I can see how "configs" didn't really fit for what these provide. The > > value associated with this key should be the resource bundles. Would > > "properties" or "resources" work? > > > > `allConfigParams` is in camel case. How about using hyphens to separate > > words for serialization? same as above, I never seen this as a convention to use hyphens in JSON. If we seen the connector api, we have consistently used configs there, might be ok to call them just configs. But I wanted ot have all since we dont slit them by type here. - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27095/#review58172 ----------------------------------------------------------- On Oct. 23, 2014, 4:35 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27095/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 4:35 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA > https://issues.apache.org/jira/browse/SQOOP-1514 > https://issues.apache.org/jira/browse/SQOOP-1512 > > and the parent ticket: > https://issues.apache.org/jira/browse/SQOOP-1509 > > It modifies the driver api and connector api. > > It adds a configurable api with java docs on how to use it. > The relevant constants have been moved to their respective classes > > There are WS, that will be cleaned up soon > > Note: Sqoop Client changes to support cname will be another RB, right now it > will support cid. > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599 > > client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0 > common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef > common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb > common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259 > common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d > common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java > PRE-CREATION > > common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java > PRE-CREATION > > common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java > cec46f6 > > common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java > f27d81d > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > 1e6da6d > common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55 > common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a > common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6 > common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c > common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41 > common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7 > common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171 > common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3 > common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137 > > common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java > 4f0c84d > common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055 > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d > core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891 > core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java > 0d9a9b8 > core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > c50e029 > > server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java > aa773a9 > server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 0cd5acb > server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java > d24ac10 > server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java > c2b1f9f > server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java > PRE-CREATION > server/src/main/webapp/WEB-INF/web.xml d31120a > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java > 819cf6a > > Diff: https://reviews.apache.org/r/27095/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
