[
https://issues.apache.org/jira/browse/SQOOP-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187309#comment-14187309
]
Hudson commented on SQOOP-1439:
-------------------------------
FAILURE: Integrated in Sqoop2-hadoop100 #632 (See
[https://builds.apache.org/job/Sqoop2-hadoop100/632/])
SQOOP-1439: Sqoop2: Validations: Remove all references to the original
Validation infastructure (abraham:
https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=a203e77264d2ba89b962c38baf10bceead06877e)
* spi/src/main/java/org/apache/sqoop/validation/Validator.java
* common/src/test/java/org/apache/sqoop/validation/TestValidation.java
* common/src/main/java/org/apache/sqoop/json/JobValidationBean.java
* core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java
* core/src/main/java/org/apache/sqoop/driver/Driver.java
* common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java
*
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
*
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
*
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
* common/src/main/java/org/apache/sqoop/model/ConfigUtils.java
* common/src/test/java/org/apache/sqoop/json/TestValidationBean.java
*
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java
* spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
* common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java
> Sqoop2: Refactor validations
> ----------------------------
>
> Key: SQOOP-1439
> URL: https://issues.apache.org/jira/browse/SQOOP-1439
> Project: Sqoop
> Issue Type: Bug
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: from/to
>
>
> On my quest to fix technical depth that I've myself put into Sqoop2, I would
> like to propose refactoring validator interface. The problems that I see:
> * Validations are *ONLY* server side, client has to always go to the sever to
> validate everything. Whereas some validations can never be executed to
> client, it would be nice to give client opportunity to run at least some
> basic validations.
> * Validations are in separate {{Validator}} class and are completely separate
> from the actual configuration objects. This makes the development quite hard
> and "disconnected".
> * Entire interface is very non-intuitive as one has to call methods where
> parameters are names of instance variables which is awful and don't provide
> any level of checking that you've set validation on the correct object.
> I would like to move the validations to annotations so that validation and
> given configuration object are in the same place. This will also allow us to
> serialize and send them to the client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
