----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27330/ -----------------------------------------------------------
(Updated Oct. 29, 2014, 10:24 p.m.) Review request for Sqoop. Changes ------- addressed 2 comments related to fromconfig change and string concate Repository: sqoop-sqoop2 Description ------- see JIRA and its parent JIRA for details All the WS stuff, I will do it in the end once the functionality is reviewd. Diffs (updated) ----- client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3 client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7 client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783 common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18 common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538 common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0 common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 2411169 connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 12ceb21 connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java 3ae64f0 core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5 server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION server/src/main/webapp/WEB-INF/web.xml 6ad90d2 shell/src/main/java/org/apache/sqoop/shell/AbortCommand.java PRE-CREATION shell/src/main/java/org/apache/sqoop/shell/AbortJobFunction.java PRE-CREATION shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 7c56980 shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 50b2e81 shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 shell/src/main/java/org/apache/sqoop/shell/SubmitCommand.java PRE-CREATION shell/src/main/java/org/apache/sqoop/shell/SubmitJobFunction.java PRE-CREATION shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 44d5920 submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 631ceca test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java af31769 test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443 tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 64b08fc Diff: https://reviews.apache.org/r/27330/diff/ Testing ------- yes Thanks, Veena Basavaraj
