----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/#review59298 -----------------------------------------------------------
Ship it! The diff_v7.patch file made it in. Also, the log message from previous review seems wrong. FileSystemAccess is an HDFS class: https://github.com/pierre/serialization/blob/master/hadoop/src/main/java/com/ning/metrics/serialization/hadoop/FileSystemAccess.java. - Abraham Elmahrek On Oct. 31, 2014, 2:59 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26678/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 2:59 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Kerberos support when starting service > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/core/SqoopServer.java > ac836c7cee010144696ab17645ccd008aed5762d > core/src/main/java/org/apache/sqoop/security/AuthenticationConstants.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthenticationError.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/security/AuthenticationHandlerFactory.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java > PRE-CREATION > dist/src/main/server/conf/sqoop.properties > bb010166120321899425f84edb8e1ad6512626d2 > pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 > security/pom.xml PRE-CREATION > > security/src/main/java/org/apache/sqoop/security/KerberosAuthenticationHandler.java > PRE-CREATION > > security/src/main/java/org/apache/sqoop/security/SimpleAuthenticationHandler.java > PRE-CREATION > server/pom.xml 67baaa57da9f69f2e8795107ca1b6186eaef2b9c > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 9c71688ade0063e0d915ef44e7b87e907a2d0e6c > > Diff: https://reviews.apache.org/r/26678/diff/ > > > Testing > ------- > > No test case till now, becasue there is no minikdc lib in support Hadoop 2 > version (2.2.0). > For Hadoop 2.2.0, there are only external KDC test cases in Hadoop itself. > For the latest Hadoop version (2.5.1), there is minikdc lib, which makes > internal KDC test easily, used by KMS etc. We have mentioned in last regular > meeting. > > If internal KDC is a must have, there are 2 options. > 1. write similar minikdc code in SQOOP. > 2. add latest verion of Hadoop (2.5.1) in security component with test scope. > (prefered) > > What do you think? Thanks in advance. > > > Thanks, > > richard zhou > >
