[
https://issues.apache.org/jira/browse/SQOOP-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192119#comment-14192119
]
Sqoop QA bot commented on SQOOP-1651:
-------------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12678500/SQOOP-1651.patch
against branch sqoop2.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All tests passed
Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/500/console
This message is automatically generated.
> Cleanup: Naming and ordering of methods in Repo relates classes
> ---------------------------------------------------------------
>
> Key: SQOOP-1651
> URL: https://issues.apache.org/jira/browse/SQOOP-1651
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Veena Basavaraj
> Assignee: Veena Basavaraj
> Fix For: 2.0.0
>
> Attachments: SQOOP-1651.patch
>
>
> this RB has 2 changes.
> for clarity in reading ( and forward thinking to separate the repo apis per
> entity so multiple repo support becomes easier) I group the link related and
> job related methods together
> Second, all the methods have the verb and then the noun convention.
> Except the 2 methods I have renamed them to be consistent, so it is clear
> than when a new methods is added we do not fight over naming conventions.
> Going forward we will document the coding guidelines for the sqoop code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
