----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27349/#review59368 -----------------------------------------------------------
Ship it! [+1](http://www.lgtm.in/p/OjnORIo9q) - Gwen Shapira On Oct. 30, 2014, 1:08 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27349/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 1:08 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1640 > https://issues.apache.org/jira/browse/SQOOP-1640 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 7e9bedfc58500ab7805dbbe722498ed88ad89c25 > Author: Abraham Elmahrek <[email protected]> > Date: Wed Oct 29 13:59:50 2014 -0700 > > SQOOP-1640: Sqoop2: Pull DatabaseProvider into sqoop-common-test module > > :000000 100644 0000000... 9fd671c... A common-test/pom.xml > :000000 100644 0000000... 8196fe2... A > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > :000000 100644 0000000... 0a12d7b... A > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > :000000 100644 0000000... 5a01841... A > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProviderFactory.java > :000000 100644 0000000... f7b91bb... A > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java > :000000 100644 0000000... 9814ac8... A > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > :000000 100644 0000000... d31bf28... A > common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java > :000000 100644 0000000... ed29a23... A > common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java > :000000 100644 0000000... d46e01d... A > common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java > :000000 100644 0000000... 9c56886... A > common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java > :000000 100644 0000000... f99d1ed... A > common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java > :100644 100644 f25a29f... 7e51b51... M pom.xml > :100644 100644 7a80710... 956aeb7... M test/pom.xml > :100644 000000 364f86d... 0000000... D > test/src/main/java/org/apache/sqoop/test/asserts/ProviderAsserts.java > :100644 100644 fb9be13... 1e90c59... M > test/src/main/java/org/apache/sqoop/test/data/Cities.java > :100644 100644 6999408... 06f386e... M > test/src/main/java/org/apache/sqoop/test/data/DataSet.java > :100644 100644 a4730c2... 7979686... M > test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java > :100644 000000 3ebdd5e... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.java > :100644 000000 330863a... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/DatabaseProviderFactory.java > :100644 000000 98e83ce... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/DerbyProvider.java > :100644 000000 4f21935... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/MySQLProvider.java > :100644 000000 4e5bb0d... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/NetezzaProvider.java > :100644 000000 5a55c85... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/OracleProvider.java > :100644 000000 06156c4... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/PostgreSQLProvider.java > :100644 000000 327c05e... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/SqlServerProvider.java > :100644 000000 a66823e... 0000000... D > test/src/main/java/org/apache/sqoop/test/db/TeradataProvider.java > :100644 100644 af31769... 06462a3... M > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > > > Diffs > ----- > > common-test/pom.xml PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProviderFactory.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java > PRE-CREATION > pom.xml f25a29f > test/pom.xml 7a80710 > test/src/main/java/org/apache/sqoop/test/asserts/ProviderAsserts.java > 364f86d > test/src/main/java/org/apache/sqoop/test/data/Cities.java fb9be13 > test/src/main/java/org/apache/sqoop/test/data/DataSet.java 6999408 > test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java a4730c2 > test/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.java 3ebdd5e > test/src/main/java/org/apache/sqoop/test/db/DatabaseProviderFactory.java > 330863a > test/src/main/java/org/apache/sqoop/test/db/DerbyProvider.java 98e83ce > test/src/main/java/org/apache/sqoop/test/db/MySQLProvider.java 4f21935 > test/src/main/java/org/apache/sqoop/test/db/NetezzaProvider.java 4e5bb0d > test/src/main/java/org/apache/sqoop/test/db/OracleProvider.java 5a55c85 > test/src/main/java/org/apache/sqoop/test/db/PostgreSQLProvider.java 06156c4 > test/src/main/java/org/apache/sqoop/test/db/SqlServerProvider.java 327c05e > test/src/main/java/org/apache/sqoop/test/db/TeradataProvider.java a66823e > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > af31769 > > Diff: https://reviews.apache.org/r/27349/diff/ > > > Testing > ------- > > mvn clean verify > -Dsqoop.hadoop.runner.class=org.apache.sqoop.test.hadoop.HadoopLocalRunner > > > Thanks, > > Abraham Elmahrek > >
