----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27589/#review59850 -----------------------------------------------------------
Ship it! Awesome stuff. Few minor comments. docs/src/site/sphinx/ClientAPI.rst <https://reviews.apache.org/r/27589/#comment101139> Haha! love this! docs/src/site/sphinx/ClientAPI.rst <https://reviews.apache.org/r/27589/#comment101142> I think mentioning connectors here is a bit confusing. The API works with configs and links, so bringing connectors to the introduction can cause a confusion between links and connectors. docs/src/site/sphinx/ClientAPI.rst <https://reviews.apache.org/r/27589/#comment101143> So I need to know these configs will exist when I try to use the API? How do I find those? docs/src/site/sphinx/ClientAPI.rst <https://reviews.apache.org/r/27589/#comment101145> Isn't the use of "object" here confusing? We are deleting the link from the DB, not just doing something to a Java object. docs/src/site/sphinx/ClientAPI.rst <https://reviews.apache.org/r/27589/#comment101148> I prefer using english here (rather than jargon): "Starting a job requires...." or make it clear its jargon: ``Job start`` requires... docs/src/site/sphinx/Tools.rst <https://reviews.apache.org/r/27589/#comment101151> accidental change? - Gwen Shapira On Nov. 4, 2014, 10:05 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27589/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 10:05 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1676 > https://issues.apache.org/jira/browse/SQOOP-1676 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA > > > Diffs > ----- > > docs/src/site/sphinx/ClientAPI.rst 7293716 > docs/src/site/sphinx/ConnectorDevelopment.rst 5e61943 > docs/src/site/sphinx/Tools.rst 6d36b27 > > Diff: https://reviews.apache.org/r/27589/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
