> On Nov. 10, 2014, 1:40 p.m., Abraham Elmahrek wrote: > > execution/mapreduce/src/test/java/org/apache/sqoop/job/util/MRJobTestUtil.java, > > line 45 > > <https://reviews.apache.org/r/27578/diff/2/?file=757265#file757265line45> > > > > What is replacing this?
http://stackoverflow.com/questions/21645431/what-are-the-replacement-for-hadoop-job-deprecated-class - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27578/#review60683 ----------------------------------------------------------- On Nov. 10, 2014, 12:49 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27578/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 12:49 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1348 > https://issues.apache.org/jira/browse/SQOOP-1348 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA > > - removed Data and TestData > - use IDF in tests, add a utlity method to set schema and IDF, > - amend CSV IDF to take schema since it is required to have schema, and add > tests to check for null schema not just emptys schema in IDF > - rename JobUtils to MRJobTestUtil > - rename the SqoopWritabelTest to TestSQ...since we want to keep this as a > convetion for all test classes, helps with code coverage tools > - fixes some names to indicate the dataformat class instead of data > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/schema/Schema.java 40c362c > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > e0e4061 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 72e95ed > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 139883e > execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java > dafdeb4 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > 78ae4ec > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java > 04fb692 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java > 68ce5ed > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java > 4e23bcb > > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestSqoopWritable.java > PRE-CREATION > > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java > 5bd11f0 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/util/MRJobTestUtil.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27578/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
