> On Nov. 10, 2014, 7:39 a.m., Qian Xu wrote: > > src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java, line 131 > > <https://reviews.apache.org/r/27659/diff/1-2/?file=751163#file751163line131> > > > > From the context, the code already knows the table name to access, can > > you use it for testing?
Probably. Either way it shouldn't matter though. > On Nov. 10, 2014, 7:39 a.m., Qian Xu wrote: > > src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java, line 133 > > <https://reviews.apache.org/r/27659/diff/1-2/?file=751163#file751163line133> > > > > Are you sure that an IOException will be thrown for priviledge reason > > instead of returning a false by `tableExists`. Maybe a test case can be > > helpful. Agreed on testing. I don't think Sqoop1 has mini-kdc yet. So we can't test it effectively. If this version proves to be buggy, we can add a configuration flag that chooses whether to authenticate or not. The difficulty with that solution is that a modification will need to be made in Oozie to support this. - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27659/#review60545 ----------------------------------------------------------- On Nov. 7, 2014, 9:55 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27659/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 9:55 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1684 > https://issues.apache.org/jira/browse/SQOOP-1684 > > > Repository: sqoop-trunk > > > Description > ------- > > commit 15a1ccdc06e7fcf541d7f7e65d3c9078ef088852 > Author: Abraham Elmahrek <[email protected]> > Date: Wed Nov 5 17:55:48 2014 -0800 > > SQOOP-1684: Use pre-existing HBase delegation token > > :100644 100644 d10050d... 25b9f3b... M > src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java d10050d > > Diff: https://reviews.apache.org/r/27659/diff/ > > > Testing > ------- > > Tested on kerberized cluster. Skipping authentication successfully if token > is provided. > > > Thanks, > > Abraham Elmahrek > >
